Adding VolumeClaimTemplate to pipelines-tutorial #95
Conversation
|
|
||
| ```bash | ||
| $ tkn pipeline start build-and-deploy \ | ||
| -w name=shared-workspace,claimName=source-pvc \ | ||
| -w name=shared-workspace,volumeClaimTemplateFile=https://raw.githubusercontent.com/openshift/pipelines-tutorial/master/01_pipeline/03_persistent_volume_claim.yaml \ |
There was a problem hiding this comment.
Can we do the same changes here https://github.com/openshift/pipelines-tutorial/blob/master/02_pipelinerun/02_build_deploy_ui_pipelinerun.yaml#L17-L18 so that it will consistent while using tkn or yaml for vote-ui
VeereshAradhya
force-pushed
the
volumeClaimTemplate-tut
branch
from
4ce2d2a
to
d05fb9f
Compare
|
I think we can use volumeClaimTemplate in both pipelinerun, this means we can remove PVC yaml also update the docs accordingly |
|
@piyush-garg The idea is to use both |
|
I think we try to keep tutorial simple. That's why we will move to single git repo example. So having only one approach is fine too. |
|
@Preeticp @savitaashture WDYT? If you all agree I will update the PR to contain only |
|
Actually it will be good if we show how we can use +1 to use |
VeereshAradhya
force-pushed
the
volumeClaimTemplate-tut
branch
from
d05fb9f
to
c05b869
Compare
| @@ -45,7 +45,7 @@ The custom resources needed to define a pipeline are listed below: | |||
| In short, in order to create a pipeline, one does the following: | |||
| * Create custom or install [existing](https://github.com/tektoncd/catalog) reusable `Tasks` | |||
| * Create a `Pipeline` and `PipelineResources` to define your application's delivery pipeline | |||
| * Create a `PersistentVolumeClaim` to provide the volume/filesystem for pipeline execution | |||
| * Create a `PersistentVolumeClaim` to provide the volume/filesystem for pipeline execution or provide a `VolumeClaimTemplate` which creates a `PersistentVolumeClaim` | |||
There was a problem hiding this comment.
I think we need to change this sentence bit because we are not creating PersistentVolumeClaim now
There was a problem hiding this comment.
It's just extra information. Anyway even VolumeClaimTemplate creates a PVC. I think it's ok to keep it :)
|
/lgtm |
|
@piyush-garg: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@savitaashture: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, savitaashture, vdemeester, VeereshAradhya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
VolumeClaimTemplateand updated thetkncommand inREADME.mdto usevolumeClaimTemplatedemo.shto useVolumeClaimTemplatefor thevote-uipipelinerun