Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-operator/config/openshift/etcd: use CGO_ENABLED for unit tests #20773

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Aug 1, 2021

This PR addresses a few changes with etcd in 3.5

  • etcd as of 3.5 no longer tracks the vendor directory so we need to pass GOFLAGS=-mod=readonly to make build
  • etcd now passes the race flag to go test which requires CGO_ENABLED true

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2021
@hexfusion
Copy link
Contributor Author

cc @lilic

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2021

@hexfusion: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/etcd/openshift-4.9/e2e-aws-upgrade e4cbdbd link /test pj-rehearse
ci/prow/pj-rehearse e4cbdbd link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor Author

hexfusion commented Aug 1, 2021

Upgrade rehearsal failure unrelated to change

Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 7a84850 into openshift:master Aug 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2021

@hexfusion: Updated the ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-etcd-openshift-4.9.yaml using file ci-operator/config/openshift/etcd/openshift-etcd-openshift-4.9.yaml

In response to this:

This PR addresses a few changes with etcd in 3.5

  • etcd as of 3.5 no longer tracks the vendor directory so we need to pass GOFLAGS=-mod=readonly to make build
  • etcd now passes the race flag to go test which requires CGO_ENABLED true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the fix-unit-env branch August 2, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants