ETCD-202: bump etcd v3.5.0 #91
Conversation
etcdserver: remove temp files in snap dir when etcdserver starting
client: fix check datascale command for https endpoints
Update go for 3.5: 1.15.x -> 1.16.3
Since the Dockerfile files are now per arch, this adjusts to detect ARCH and builds docker release from the Dockerfile.<ARCH> file.
This fixes so that the ENV vars are taken in the same way as for etcd binary.
Makefile, build.sh: Fix build process
doc: fix branch management link
…ith ?exclude=NOSPACE
…ealth_check etcdhttp/metrics.go: exclude alarms from health check conditionally with `?exclude=NOSPACE`
Makefile: Use `gcloud auth configure-docker` instead of `gcloud docker ...` for test-images
(no)StoreV2 (Part 3): Applying consistency fix: ClusterVersionSet (and co) might get not applied on v2store
…r-testing mvcc/backend tests: Refactor: Do not mix testing&prod code.
…d as codes.Canceled, codes.DeadlineExceeded instead of 'codes.Unknown'
…text Errors: `context cancelled` or `context deadline exceeded` are exposed as codes.Canceled, codes.DeadlineExceeded instead of 'codes.Unknown'
Infrequently the test flaked. Reproducable with: ``` go test go.etcd.io/etcd/tests/v3/integration --run TestFirstCommitNotification --count=500 ``` The moveLeader finishes when configchange is commited by quorum. It doesn't guarantee that the 'empty' record was committed by the new leader. From time to time happened that appliedLeaderIndex was returning 9 (without empty entry) and the test flaked. In healthy case the appliedIndex returned 10. Fixed by putting kv pair after leader change. The pair is guaranteed to be stored on index when put finishes (so the empty entry as well).
…stCommitNotification Deflake: TestFirstCommitNotification
functional: add disk io failure case
etcdserver/mvcc: update tw.trace.Step condition
correct 'backend' (bbolt) context in aspect of membership.
Prior to this change the 'restored' backend used to still contain:
- old memberid (mvcc deletion used, why the membership is in bolt
bucket, but not mvcc part):
```
mvs := mvcc.NewStore(s.lg, be, lessor, ci, mvcc.StoreConfig{CompactionBatchLimit: math.MaxInt32})
defer mvs.Close()
txn := mvs.Write(traceutil.TODO())
btx := be.BatchTx()
del := func(k, v []byte) error {
txn.DeleteRange(k, nil)
return nil
}
// delete stored members from old cluster since using new members
btx.UnsafeForEach([]byte("members"), del)
```
- didn't get new members added.
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
…s not part of member list and dataDir exists Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
@hexfusion: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
hexfusion
force-pushed
the
etcd-rebase-v3.5.0
branch
from
4510e90
to
33b3996
Compare
…r when its cert has non empty CN CARRY: This patch is required to allow metrics cert to auth with CN in cert. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
/retest |
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
/retest |
|
@hexfusion: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Quorum guard failures fixed by |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
…on tests with unit etcd 3.5 will not allow integration tests to run outside of test/integration. This change breaks out the logic into a more testable path allowing coverage and not requiring breaking out discover-etcd-initial-cluster into a seperate module yet. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
unit tests should pass with openshift/release#20773. they pass locally so the issue is with CI config. |
|
/retest PR was merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.