-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e-vsphere-ipi-ovn-migration-sdn #37295
Add e2e-vsphere-ipi-ovn-migration-sdn #37295
Conversation
Since the introduction of OCPBUGS-7467 we are able to use IP addresses as part of the kubeconfig. By using this the CI jobs can safely remove the DNS provision/deprovision, leaving a simpler workflow, one less point of failure, and one less dependency.
Unfortunately it looks like DEBUG might expose credential info from ignition. Let's keep just INFO level for now until we figure a better way to enable DEBUG. Add e2e-vsphere-ipi-ovn-migration-sdn Add e2e-vsphere-ipi-ovn-migration-sdn
@weliang1: the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm |
@liangxia PTAL! |
@@ -2845,6 +2845,18 @@ tests: | |||
test: | |||
- chain: openshift-e2e-test-qe | |||
workflow: cucushift-installer-rehearse-vsphere-ipi-sdn | |||
- as: vsphere-ipi-ovn-migration-sdn-p2-f7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to sort the tests based on the name, also add it to 4.14, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liangxia I though I insert file based on the names as below? Please advise, thanks!
- as: vsphere-ipi-sdn-p2-f7
- as: vsphere-ipi-ovn-migration-sdn-p2-f7
- as: vsphere-ipi-zones-p2-f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, vsphere-ipi-ovn should sort before vsphere-ipi-sdn
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weliang1, zhaozhanqi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@weliang1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is for https://issues.redhat.com/browse/NP-639: Support for ovn-kubernetes to openshift-sdn CNI Migration
Comparing sdn2ovn migration, we do not think many customers will do the ovn2sdn migration, so one workflow testing should be enough.
The reason to pick vsphere cluster is because most customer OCP clusters are running in vsphere.
@zhaozhanqi PTAL