Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e-vsphere-ipi-ovn-migration-sdn #37295

Closed
wants to merge 4 commits into from
Closed

Add e2e-vsphere-ipi-ovn-migration-sdn #37295

wants to merge 4 commits into from

Conversation

weliang1
Copy link
Contributor

@weliang1 weliang1 commented Mar 14, 2023

This PR is for https://issues.redhat.com/browse/NP-639: Support for ovn-kubernetes to openshift-sdn CNI Migration

Comparing sdn2ovn migration, we do not think many customers will do the ovn2sdn migration, so one workflow testing should be enough.

The reason to pick vsphere cluster is because most customer OCP clusters are running in vsphere.

@zhaozhanqi PTAL

pacevedom and others added 3 commits March 14, 2023 13:07
Since the introduction of OCPBUGS-7467 we are able to use IP
addresses as part of the kubeconfig. By using this the CI jobs
can safely remove the DNS provision/deprovision, leaving a simpler
workflow, one less point of failure, and one less dependency.
Unfortunately it looks like DEBUG might expose credential info from
ignition. Let's keep just INFO level for now until we figure a better
way to enable DEBUG.

Add e2e-vsphere-ipi-ovn-migration-sdn

Add e2e-vsphere-ipi-ovn-migration-sdn
@openshift-ci-robot
Copy link
Contributor

@weliang1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@zhaozhanqi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@weliang1
Copy link
Contributor Author

@liangxia PTAL!

@@ -2845,6 +2845,18 @@ tests:
test:
- chain: openshift-e2e-test-qe
workflow: cucushift-installer-rehearse-vsphere-ipi-sdn
- as: vsphere-ipi-ovn-migration-sdn-p2-f7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to sort the tests based on the name, also add it to 4.14, too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangxia I though I insert file based on the names as below? Please advise, thanks!

  • as: vsphere-ipi-sdn-p2-f7
  • as: vsphere-ipi-ovn-migration-sdn-p2-f7
  • as: vsphere-ipi-zones-p2-f7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, vsphere-ipi-ovn should sort before vsphere-ipi-sdn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weliang1, zhaozhanqi
Once this PR has been reviewed and has the lgtm label, please assign eloycoto, jianlinliu, liangxia, stlaz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weliang1
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

@weliang1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deprecate-templates 3135714 link true /test deprecate-templates
ci/prow/prow-config-semantics 3135714 link true /test prow-config-semantics
ci/prow/ci-operator-config-metadata 3135714 link true /test ci-operator-config-metadata
ci/prow/prow-config-filenames 3135714 link true /test prow-config-filenames
ci/prow/step-registry-shellcheck 3135714 link true /test step-registry-shellcheck
ci/prow/ordered-prow-config 3135714 link true /test ordered-prow-config
ci/prow/yamllint 3135714 link true /test yamllint
ci/prow/ci-operator-config 3135714 link true /test ci-operator-config
ci/prow/config 3135714 link true /test config
ci/prow/release-controller-config 3135714 link true /test release-controller-config
ci/prow/owners 3135714 link true /test owners
ci/prow/openshift-image-mirror-mappings 3135714 link true /test openshift-image-mirror-mappings
ci/prow/generated-config 3135714 link true /test generated-config
ci/prow/build-clusters 3135714 link true /test build-clusters
ci/prow/check-gh-automation 3135714 link true /test check-gh-automation
ci/prow/core-valid 3135714 link true /test core-valid
ci/prow/prow-config 3135714 link true /test prow-config
ci/prow/boskos-config-generation 3135714 link true /test boskos-config-generation
ci/prow/correctly-sharded-config 3135714 link true /test correctly-sharded-config
ci/prow/step-registry-metadata 3135714 link true /test step-registry-metadata
ci/prow/ci-operator-registry 3135714 link true /test ci-operator-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
8 participants