Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-vsphere-ipi-ovn-migration-sdn-workflow #37660

Closed
wants to merge 1 commit into from
Closed

add-vsphere-ipi-ovn-migration-sdn-workflow #37660

wants to merge 1 commit into from

Conversation

weliang1
Copy link
Contributor

Same PR #37442 keep failing.

This PR is for https://issues.redhat.com/browse/NP-639: Support for ovn-kubernetes to openshift-sdn CNI Migration

Comparing sdn2ovn migration, we do not think many customers will do the ovn2sdn migration, so one workflow testing should be enough.

The reason to pick vsphere cluster is because most customer OCP clusters are running in vsphere.

This PR fixed all the issues mentioned in PR #37295
@liangxia @zhaozhanqi PTAL

@openshift-ci openshift-ci bot requested review from bandrade and neisw March 24, 2023 15:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weliang1
Once this PR has been reviewed and has the lgtm label, please assign jhou1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@weliang1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

1 similar comment
@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

2 similar comments
@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

4 similar comments
@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2023
@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

1 similar comment
@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@zhaozhanqi
Copy link
Contributor

zhaozhanqi commented Mar 28, 2023 •
edited

above job failed due to one case in oc debug

      �[36m�[33m[02:31:40] INFO> Shell Commands: oc debug  --kubeconfig=/alabama/workdir/vsphere-ipi-ovn-migration-sdn-p2-f7-cucushift-upgrax/ocp4_admin.kubeconfig -n prj-vsphere-ipi-ovn-migration-sdn-p2-f7-cucushift-upgrax-gns9 --image=quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:02841b726f9f5f33323f1f7947fdb6fff751458c958e6db49949279105bbc45b node/ci-op-0ify7zn7-96e53-88dm6-master-0 -- chroot /host/ bash -c cd\ \'/tmp/workdir/vsphere-ipi-ovn-migration-sdn-p2-f7-cucushift-upgrax\''�[0m
      �[36m'cat\ /etc/kubernetes/kubelet.conf�[0m�[0m
      �[36m�[0m
      �[36mSTDERR:�[0m
      �[36mStarting pod/ci-op-0ify7zn7-96e53-88dm6-master-0-debug ...�[0m
      �[36mTo use host binaries, run `chroot /host`�[0m
      �[36m�[0m
      �[36mRemoving debug pod ...�[0m
      �[36mError from server (BadRequest): container "container-00" in pod "ci-op-0ify7zn7-96e53-88dm6-master-0-debug" is waiting to start: ContainerCreating�[0m�[0m
      �[36m�[33m[02:31:41] INFO> Exit Status: 1�[0m�[0m
    �[31mThen the step should �[31m�[1msucceed�[0m�[0m�[31m�[90m                                        # features/step_definitions/common.rb:4�[0m�[0m
�[31m      the step failed (RuntimeError)�[0m

@zhaozhanqi
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

1 similar comment
@zhaozhanqi
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1 weliang1 mentioned this pull request Mar 28, 2023
Closed
@weliang1
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

@weliang1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 739c895 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7
ci/prow/supplemental-ci-images-mapping-files 739c895 link true /test supplemental-ci-images-mapping-files

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@weliang1 weliang1 closed this Apr 3, 2023
@weliang1 weliang1 mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandrade bandrade Awaiting requested review from bandrade

@neisw neisw Awaiting requested review from neisw

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
3 participants
@weliang1 @openshift-ci-robot @zhaozhanqi