Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vsphere-ipi-ovn-migration-sdn-workflow #37442

Closed
wants to merge 1 commit into from
Closed

Add vsphere-ipi-ovn-migration-sdn-workflow #37442

wants to merge 1 commit into from

Conversation

weliang1
Copy link
Contributor

Same PR #37295 is messed up and closed.

This PR is for https://issues.redhat.com/browse/NP-639: Support for ovn-kubernetes to openshift-sdn CNI Migration

Comparing sdn2ovn migration, we do not think many customers will do the ovn2sdn migration, so one workflow testing should be enough.

The reason to pick vsphere cluster is because most customer OCP clusters are running in vsphere.

This PR fixed all the issues mentioned in PR #37295
@liangxia @zhaozhanqi PTAL

@openshift-ci-robot
Copy link
Contributor

@weliang1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weliang1
Once this PR has been reviewed and has the lgtm label, please assign jhou1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weliang1
Copy link
Contributor Author

@liangxia PTAL

@liangxia
Copy link
Member

/assign @zhaozhanqi

@zhaozhanqi
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@zhaozhanqi
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@zhaozhanqi
Copy link
Contributor

zhaozhanqi commented Mar 21, 2023

@weliang1 FYI, There is changes in prow CI, when one PR is filed. there will not jobs be triggered by auto in order to save resource or reduce not related failure. so we need to trigger we wanted job by manual. like above new added jobs

@weliang1
Copy link
Contributor Author

/retest-required

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

1 similar comment
@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-ipsec-p2-f7

@openshift-ci-robot
Copy link
Contributor

@weliang1: job(s): , periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-ipsec-p2-f7 either don't exist or were not found to be affected, and cannot be rehearsed

@weliang1
Copy link
Contributor Author

@liangxia The job of /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 passed.

But the job of periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-ipsec-p2-f7 failed on Step vsphere-ipi-ovn-migration-sdn-p2-f7-ipi-install-install failed after 2h10m6s.

Could you help to look at the log to see the failure is caused by my new commit or it's a know issue? Thanks!

@weliang1
Copy link
Contributor Author

@liangxia PTAL

steps:
cluster_profile: vsphere
env:
UPGRADE_CHECK_RUN_TAGS: '@4.13 and @vsphere-ipi and @upgrade-check and @network-openshiftsdn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo of 4.13 ?

@weliang1
Copy link
Contributor Author

/retest

@weliang1
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

@weliang1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7 a7aeabd7a0f7a7f71290e654df7d1187be7db925 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-migration-sdn-p2-f7
ci/prow/step-registry-shellcheck 86222f4 link true /test step-registry-shellcheck
ci/prow/step-registry-metadata 86222f4 link true /test step-registry-metadata
ci/prow/config 86222f4 link true /test config
ci/prow/yamllint 86222f4 link true /test yamllint
ci/prow/check-gh-automation 86222f4 link true /test check-gh-automation
ci/prow/release-controller-config 86222f4 link true /test release-controller-config
ci/prow/owners 86222f4 link true /test owners
ci/prow/build-clusters 86222f4 link true /test build-clusters
ci/prow/correctly-sharded-config 86222f4 link true /test correctly-sharded-config
ci/prow/generated-config 86222f4 link true /test generated-config
ci/prow/prow-config-filenames 86222f4 link true /test prow-config-filenames
ci/prow/ci-operator-config-metadata 86222f4 link true /test ci-operator-config-metadata
ci/prow/ordered-prow-config 86222f4 link true /test ordered-prow-config
ci/prow/ci-operator-registry 86222f4 link true /test ci-operator-registry
ci/prow/deprecate-templates 86222f4 link true /test deprecate-templates
ci/prow/ci-operator-config 86222f4 link true /test ci-operator-config
ci/prow/openshift-image-mirror-mappings 86222f4 link true /test openshift-image-mirror-mappings
ci/prow/prow-config-semantics 86222f4 link true /test prow-config-semantics
ci/prow/core-valid 86222f4 link true /test core-valid

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants