OCM-5358 | fix: add a warning message when using best effort deletion #1668
Conversation
openshift-ci
bot
added
the
approved
cmd/dlt/cluster/cmd.go
Outdated
| @@ -85,6 +85,11 @@ func run(cmd *cobra.Command, _ []string) { | |||
|
|
|||
| cluster := r.FetchCluster() | |||
|
|
|||
| if args.bestEffort { | |||
| r.Reporter.Warnf("Deleting a cluster with 'best effort' means that certain resources may be left behind " + | |||
There was a problem hiding this comment.
@oriAdler Wondering if we should include the clusterKey and AWS account details in this message so something like:
r.Reporter.Warnf("Deleting cluster '%s' with 'best effort' means that certain resources may be left behind in AWS account '%s'. These resources will need to be deleted manually.", r.GetClusterKey(),r.Creator.AccountID)
Just makes it a little more helpful to the user to verify that they're deleting the correct cluster and which AWS account might have resources left over.
There was a problem hiding this comment.
Good point, added, thanks.
Notify the user about cloud resources that may left behind when using the 'best effort' flag.
|
@oriAdler: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gdbranco, oriAdler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Notify the user about cloud resources that may left behind when using the 'best effort' flag.