Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6926 | fix: Support local envs in GetEnv() #1870

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

tirthct
Copy link
Contributor

@tirthct tirthct commented Mar 21, 2024

https://issues.redhat.com/browse/OCM-6926

Changed

  • Added complete URL check as a fallback mechanism for GetEnv() in case of specific local or other URLs
  • Added test case to confirm the behavior

Tested

  • Local env should be supported in GetEnv() : tested

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.47%. Comparing base (b049fc4) to head (5985d53).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
+ Coverage   20.91%   21.47%   +0.56%     
==========================================
  Files         103      113      +10     
  Lines       17351    18664    +1313     
==========================================
+ Hits         3629     4009     +380     
- Misses      13447    14349     +902     
- Partials      275      306      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/ocm/config.go Outdated Show resolved Hide resolved
pkg/ocm/config.go Outdated Show resolved Hide resolved
@gdbranco
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco, tirthct

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco, tirthct

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@tirthct: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 94a5865 into openshift:master Mar 25, 2024
9 checks passed
@tirthct tirthct deleted the ocm-6926 branch March 25, 2024 14:52
gdbranco pushed a commit that referenced this pull request Mar 25, 2024
OCM-6926 | fix: Support local envs in GetEnv()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants