Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7136 | fix: support create breakglasscredential without optional flags #1897

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

chenz4027
Copy link
Contributor

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 21.68%. Comparing base (50a6168) to head (cc0737b).
Report is 10 commits behind head on master.

Files Patch % Lines
cmd/create/breakglasscredential/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   21.89%   21.68%   -0.21%     
==========================================
  Files         117      117              
  Lines       18929    19312     +383     
==========================================
+ Hits         4144     4188      +44     
- Misses      14471    14810     +339     
  Partials      314      314              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…flags

Signed-off-by: Maggie Chen <magchen@redhat.com>

add test coverage

Signed-off-by: Maggie Chen <magchen@redhat.com>
@robpblake
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7ca8383 into openshift:master Apr 3, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-7136 branch May 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants