Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7412 | fix: list instance types filter by region requires installer role arn #1924

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Apr 11, 2024

OCM-7412

What

Adjusts to allow to supply a role-arn and uses interactive mode to filter existing installer role arns in logged in account

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.91%. Comparing base (9355e1f) to head (03a90e7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
+ Coverage   21.76%   21.91%   +0.14%     
==========================================
  Files         118      118              
  Lines       19775    19821      +46     
==========================================
+ Hits         4304     4343      +39     
- Misses      15145    15152       +7     
  Partials      326      326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ciaranRoche
Copy link
Member

Can we update the ticket to describe what we are changing here, as current linked ticket is closed, want to make sure this goes through QE.

Other than that LGTM

@gdbranco gdbranco changed the title OCM-1733 | fix: list instance types filter by region requires installer role arn OCM-7412 | fix: list instance types filter by region requires installer role arn Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@gdbranco: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,gdbranco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 91dfc29 into openshift:master Apr 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants