Standalone repo #3
Conversation
Specifically, in the openshift/release repo using tools/hack/golang/update <path to catalog git checkout> service-catalog Only modifications made from the vanilla configuration was OS_GO_PACKAGE and OS_CROSS_COMPILE_TARGETS in hack/lib/constants.sh.
TODO items removed/changed. Also call hack scripts directly instead of using makefile targets.
|
woohoo! |
| %if 0%{do_build} | ||
| %if 0%{make_redistributable} | ||
| # Create Binaries for all internally defined arches | ||
| %{os_git_vars} hack/build-cross.sh |
There was a problem hiding this comment.
Please always use make build-cross
There was a problem hiding this comment.
I didn't pull in the Makefile from origin. Are you sure this isn't workable?
There was a problem hiding this comment.
I don't think we should block on getting the build just-so in this PR, since, as I understand it, creation of the distgit repo is gated on having an RPM spec.
Is it cool if we whittle on the Makefile in a follow-up and just get the gears moving on the distgit repo for now?
There was a problem hiding this comment.
The makefile is automatically injected by the sync tool. You used the sync tool right?
There was a problem hiding this comment.
Apparently it doesn't overwrite an already existing Makefile, so I didn't notice the tool generated one. But yes, I did use the tool.
|
You shouldn’t have to build the source images, they can be pulled from the hub. |
|
Merging so that internal repo creation can proceed. |
This pulls in the origin tooling to allow building service-catalog (and svcat) RPMs within this repo, along with the service-catalog image too.