Rebase 03/06/24 #52
Merged
Rebase 03/06/24 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Watch RPC of lvmd's VGService is expected to notify VG information periodically to its watchers. However, when lvmd is embedded into topolvm-node, Watch RPC sends VG info only once on startup time and does nothing after that unless LVService invokes LVM commands for RPCs. This commit addresses the issue. Fixes: c5f17a4 ("feat: implement embed-lvmd") Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
lvmd: fix Watch RPC to notify VG info periodically when embedded
pkg -> cmd e2e -> test/e2e util/testing -> test/util controllers -> internal/controller other sources -> internal/* ref: https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4 Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
The same test is executed on the test target in the Makefile. Therefore, this one is removed. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
ref: #840 (comment) ref: #840 (comment) Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
Bumps the github-actions-update group with 1 update: [azure/setup-helm](https://github.com/azure/setup-helm). Updates `azure/setup-helm` from 3 to 4 - [Release notes](https://github.com/azure/setup-helm/releases) - [Commits](Azure/setup-helm@v3...v4) --- updated-dependencies: - dependency-name: azure/setup-helm dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-update ... Signed-off-by: dependabot[bot] <support@github.com>
Change directory tree to the new kubebilder template
…-actions-update-ec2bd254e3 build(deps): bump the github-actions-update group with 1 update
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Introduce 4096 byte Sector Size Minimum for Rounding LV Sizes on Creation and Resizing
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.