Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-31704: Stop checking CloudControllerOwner #2121

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

sebsoto
Copy link
Contributor

@sebsoto sebsoto commented Apr 3, 2024

Backport of #2117

This commit reacts to
openshift/cluster-cloud-controller-manager-operator@65c07a6

There is no longer a CloudControllerOwner condition on the CCM clusteroperator, as external cloud controllers are now fully default. WMCO will no longer check for this condition, and the logic depending on it should now always be done.

This commit reacts to
openshift/cluster-cloud-controller-manager-operator@65c07a6

There is no longer a CloudControllerOwner condition on the CCM
clusteroperator, as external cloud controllers are now fully default.
WMCO will no longer check for this condition, and the logic depending
on it should now always be done.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 3, 2024

/jira cherrypick OCPBUGS-31626

@openshift-ci-robot
Copy link

@sebsoto: Jira Issue OCPBUGS-31626 has been cloned as Jira Issue OCPBUGS-31704. Will retitle bug to link to clone.
/retitle OCPBUGS-31704: Stop checking CloudControllerOwner

In response to this:

/jira cherrypick OCPBUGS-31626

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 3, 2024

/retitle [release-4.15] OCPBUGS-31704: Stop checking CloudControllerOwner

@openshift-ci openshift-ci bot changed the title Stop checking CloudControllerOwner OCPBUGS-31704: Stop checking CloudControllerOwner Apr 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 3, 2024
@openshift-ci-robot
Copy link

@sebsoto: This pull request references Jira Issue OCPBUGS-31704, which is invalid:

  • expected dependent Jira Issue OCPBUGS-31626 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit reacts to
openshift/cluster-cloud-controller-manager-operator@65c07a6

There is no longer a CloudControllerOwner condition on the CCM clusteroperator, as external cloud controllers are now fully default. WMCO will no longer check for this condition, and the logic depending on it should now always be done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto sebsoto changed the title OCPBUGS-31704: Stop checking CloudControllerOwner [release-4.15] OCPBUGS-31704: Stop checking CloudControllerOwner Apr 3, 2024
@sebsoto sebsoto marked this pull request as ready for review April 3, 2024 15:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alinaryan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 3, 2024

/approve cancel

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@mansikulkarni96
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 3, 2024

/test remaining-required

@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 4, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2024
@openshift-ci-robot
Copy link

@sebsoto: This pull request references Jira Issue OCPBUGS-31704, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-31626 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31626 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from rrasouli April 4, 2024 13:09
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 528d921 and 2 for PR HEAD 54729bf in total

@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 4, 2024

/retest-required

1 similar comment
@sebsoto
Copy link
Contributor Author

sebsoto commented Apr 5, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

@sebsoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 80545cd into openshift:release-4.15 Apr 5, 2024
17 checks passed
@openshift-ci-robot
Copy link

@sebsoto: Jira Issue OCPBUGS-31704: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31704 has been moved to the MODIFIED state.

In response to this:

Backport of #2117

This commit reacts to
openshift/cluster-cloud-controller-manager-operator@65c07a6

There is no longer a CloudControllerOwner condition on the CCM clusteroperator, as external cloud controllers are now fully default. WMCO will no longer check for this condition, and the logic depending on it should now always be done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants