Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

[3] Detect possible dead code in fabric8-analytics repositories #3808

Closed
15 tasks done
tisnik opened this issue Jun 15, 2018 · 0 comments
Closed
15 tasks done

[3] Detect possible dead code in fabric8-analytics repositories #3808

tisnik opened this issue Jun 15, 2018 · 0 comments

Comments

@tisnik
Copy link
Collaborator

tisnik commented Jun 15, 2018

Planner issue: https://openshift.io/openshiftio/openshiftio/plan/detail/2615

We'd need to improve code quality by detecting (and removing) all dead code found in fabric8-analytics repositories. It can't be done fully automatically because of highly dynamic nature of Python and also because some tasks are executed via flow declaration created outside actual sources. OTOH simple cases might be covered.

Acceptance criteria

All following repositories are checked by new script(s):

  • f8a-server-backbone
  • fabric8-analytics-api-gateway
  • fabric8-analytics-auth
  • fabric8-analytics-data-model
  • fabric8-analytics-ingestion
  • fabric8-analytics-jobs
  • fabric8-analytics-license-analysis
  • fabric8-analytics-npm-insights
  • fabric8-analytics-nvd-toolkit
  • fabric8-analytics-server
  • fabric8-analytics-stack-analysis
  • fabric8-analytics-tagger
  • fabric8-analytics-version-comparator
  • fabric8-analytics-worker
  • fabric8-gemini-server

Note for devels/QA

We might try to use vulture
https://pypi.org/project/vulture/

@tisnik tisnik added this to the Analytics Backlog milestone Jun 15, 2018
@tisnik tisnik self-assigned this Jun 15, 2018
@tisnik tisnik modified the milestones: Analytics Backlog, 152, Sprint 152 Jul 17, 2018
@tisnik tisnik changed the title Detect possible dead code in fabric8-analytics repositories [3] Detect possible dead code in fabric8-analytics repositories Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.