Not connecting to SSID2 - [solved]

[xjikka]

I am trying to use SSID2 with no success. It always connects to SSID1 only (CFG_GetWiFiSSID() and CFG_GetWiFiPass()).
I couldn't find code in the source code that uses CFG_GetWiFiSSID2() and CFG_GetWiFiPass2().
Is SSID2 solved somehow differently, or is it not yet implemented?

[MaxineMuster]

It's not yet implemented, as you found out correctly.
Maybe a hint in GUI would be helpful

[xjikka]

It's not yet implemented, as you found out correctly. Maybe a hint in GUI would be helpful

I agree. Maybe some change like this:

http_fns.zip
(not tested, just suggestion)

[xjikka]

Anyway, I need SSID2 and will make some simple changes in the code to make it working somehow. If it's at least somewhat usable, I'll post it here.

[xjikka]

I have SSID2 simple mod done. It is tested on BK7231N, but with these simple changes it should work on any platform.

How does it work:
It tries g_SSIDSwitchAfterTry times to connect to the SSID and if it fails it switches to SSID2 (if set) and so on after 3 more failed attempts back to SSID and so on.

Here are the differences:
main...xjikka:OpenBK7231T_App:ssid2mod

[xjikka]

If You will find it OK, I can submit these changes here.

[MaxineMuster]

Thanks for your code!

My personal approach would be a bit different, I would make the first SSID "preferred" so in pseudo code (I will "rename" SSID to SSID1 to get it clearer ;-)):
Every time I try to connect to WiFi, first try SSID1 and increment a counter
If counter > threshold, also try SSID2

If WiFi is connected, reset counter.

But I hope it's o.k. if I give some feedback on your code?
Because I think it could be simplified in some points:

// static int g_SSIDactual = 0;			// 0=firsttime 1=ssid1 2=ssid2		

static int g_SSIDactual = 0;			// make it easy - default to first SSID --> no need for "if (g_SSIDactual == 0)"
						// to save some caclulation, use 0 and 1 (it's easy to "toggle" between 0 and 1) 0=SSID1 1=SSID2

with this "change" (0=SSID1 and 1=SSID2) the check can be very short:

void CheckForSSID12_Switch() {
#if ALLOW_SSID2
	// nothing to do if SSID2 is unset or we are below counter
	if ( (CFG_GetWiFiSSID2() == "") || ( g_SSIDSwitchCnt++ <= g_SSIDSwitchAfterTry) ) return;
	// if we are here, SSID2 is set AND counter is over number of tries, so do the switch ;-)
	g_SSIDSwitchCnt = 0;	// reset counter
	g_SSIDactual ^= 1;	// toggle value 0 ^ 1 = 1 and 1 ^ 1 = 0
	ADDLOGF_INFO("WiFi SSID: switching to SSID%i\r\n",g_SSIDactual+1);
#endif
}

Not tested, just coded ;-)

Of course, "CFG_GetWiFiSSIDX()" and "CFG_GetWiFiPassX()" need modification, to to reflect 0 and 1 (instead of 1 and 2) for SSID and SSID2

Once again, I really appreciate your code, it's meant as a positive feedback.

[xjikka]

I understand, but the reason for int g_SSIDactual = 0=first time was that:
We know that the WiFi connection has not been started yet
We can parametrically change the preferred SSID by simply adding preferred SSID as a parameter
We can possibly have multiple SSIDs (3,4...)

[xjikka]

For example, if it is a device that changes location, then if there is a prefered SSID parameter, the preferred SSID could be changed by script when device changes location. Switching to another SSID usually takes about 1 minute after restart.

[MaxineMuster]

... but even with more SSIDs I don't see why we can't simply set the SSID to the (wished) preferred SSID and then start the process. In "my" proposal: If you prefer SSID2, set g_SSIDactual=1 once, before starting the process.

So a "set_preferred_ssid" would mean: "g_SSIDactual= (preferred SSID) ;g_SSIDSwitchCnt = 0;"

[xjikka]

OK. I agree. The power is in simplicity. I will change it.

[MaxineMuster]

BTW: Even if you want to go for more than 2 SSIDs in the future, I would propose to "start" with 0 for SSID1.
Then "next SSID" would be "(g_SSIDactual+1)%numberOfSSIDs"

[openshwprojects]

very good job guys, thank you, but here is one issue to fix:
(CFG_GetWiFiSSID2() == "")
this will not work, it's C, you are comparing pointers. It will always be false. You need to do:
(CFG_GetWiFiSSID2()[0] == 0)
to check for empty strings.

Apart from that, seems good so far, open PR when you're ready