Leave experimental data alone when cleaning up motion objects #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkuchida Would you have a chance to check this has been fixed in this PR artifact? Thank you |
|
The Issue that was raised in #1168 has been fixed. Minor note: The muscles change color after clicking Poses -> Default (see below). Not sure why… presumably the location of a light is being updated, but it seems like this type of update should occur when the model gets the focus back (i.e. after double-clicking "arm26" in the Navigator) rather than when Poses -> Default is clicked.
|
This was referenced Jun 26, 2022
|
Muscle changing color when state is changed since 4.0 e.g. by manually changing coordinates is expected behavior, otherwise you have inconsistent muscle colors and coordinates. |
|
Thanks for testing @tkuchida |
aymanhab
added a commit
that referenced
this pull request
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave experimental data alone upon motion change
Fixes issue #1168
Brief summary of changes
Testing I've completed
CHANGELOG.md (choose one)