Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to metabolic example package #105

Merged
merged 2 commits into from
Nov 11, 2018

Conversation

jimmyDunne
Copy link
Member

PR addresses address' #102 with a minimum set of changes that allows the Metabolics tutorial to be completed. I am performing a tutorial refactoring in #104, but those changes won't be finished before the release.

Changes made

Cmake changes for building the file tree for the example. Models, tutorial files, and data have been placed such that the example can be run without error. The CMC setup files, External Loads setup file, and experimental data are in the top directory because of issues OpenSim has with paths to files.

Updats to the scripts were performed in #103

Tests that I have completed

  • Built locally to ensure that the CMake changes build the directory structure.
  • Run through the example using the locally build directory to check that the setup files work as is and that the scripts generate the correct outputs.

To be completed

  • Once reviewed, I will update the tutorial instructions to use the local files (rather than downloading a folder of scripts.

@jimmyDunne jimmyDunne added this to the 20181105 milestone Nov 11, 2018
Copy link
Member

@chrisdembia chrisdembia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to fix indentation in CMakeLists.txt.

We might have fixed the paths issue such that the files no longer need to be rearranged (opensim-org/opensim-core#2366), though I am still fine with this new organization.

It would be good to also delete the duplicate scripts from the GUI (in a separate PR).

@chrisdembia chrisdembia merged commit c5c129b into master Nov 11, 2018
@chrisdembia chrisdembia deleted the minor_updates_to_metabolics_example branch November 11, 2018 19:00
@jimmyDunne
Copy link
Member Author

You're the best!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants