Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uniform-length batching (smart batching) [resolved #82] - Soohwan Kim #83

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Add uniform-length batching (smart batching) [resolved #82] - Soohwan Kim #83

merged 1 commit into from
Aug 29, 2021

Conversation

sooftware
Copy link
Member

@sooftware sooftware commented Aug 29, 2021 •
edited
Loading

What does this PR do?

image

Resolved #82

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

@hasangchun

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag

@sooftware sooftware requested a review from upskyy August 29, 2021 11:08
@sooftware sooftware added the WIP ongoing label Aug 29, 2021
@sooftware
Copy link
Member Author

@hasangchun I add a smart batching mechanism. Check it.

@sooftware sooftware merged commit 0e77a6e into main Aug 29, 2021
@sooftware sooftware added DONE and removed WIP ongoing labels Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upskyy upskyy Awaiting requested review from upskyy

Assignees

@upskyy upskyy

Labels
DONE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add uniform length batching
2 participants
@sooftware @upskyy