Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dpp-fiscal version #33

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Bump dpp-fiscal version #33

merged 3 commits into from
Apr 30, 2018

Conversation

akariv
Copy link
Member

@akariv akariv commented Apr 28, 2018

This PR should resolve the 'failed to cast number' errors that are popping lately.

Problem was that in the pipeline, groupChar was ignored at some point so I added a step to cast the numeric values before that happens.

(actual fix is in dpp-fiscal)

@akariv akariv requested a review from brew April 28, 2018 20:30
@akariv
Copy link
Member Author

akariv commented Apr 28, 2018

Added another fix: avoid using 'id' as a column name, as it's quite common for datasets to contain it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants