change sub path of the package url #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brew Sorry for the inconvenience, I did not realized that we also need to remove the '/final/' part from the returned package URL. I added another regex expression to remove it in this PR. Thanks. |
brew
suggested changes
May 9, 2018
| datapackage_url = \ | ||
| re.sub(r'https?://datastore\.openspending\.org/', | ||
| 'https://s3.amazonaws.com/datastore.openspending.org/', | ||
| datapackage_url) | ||
| re.sub(r'/final/datapackage.json', '/datapackage.json', datapackage_url)) |
There was a problem hiding this comment.
I think you should escape the period in r'/final/datapackage.json'.
|
@brew Thanks, I have made the period escape and solved linting issues. |
|
This should be deployed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pull request 34, the modification to the returned package URL path is not enough, we also need to remove the sub path '/final/' from the returned URL.