Implement new Search#has function accepting resource type as param #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
ellykits
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Mar 21, 2023
- With unmerged PR #1 - With unmerged PR google#1669 - With unmerged PR google#1927 - With unmerged PR google#1917
engine/src/test/java/com/google/android/fhir/search/SearchTest.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/search/NestedSearch.kt
Outdated
Show resolved
Hide resolved
- Use named paramaters as well as rename lambda parameter Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
omarismail94
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1921
Description
Implemented a new
Search#hasfunction that accepts resource type as parameter and is not reified.Alternative(s) considered
The alternative was to update the existing function that is reified and based on generic types. Chose this approach to provide an alternative API for using
Search#hasfunction instead of refactoring the existing one.Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.