Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Support P2P #2810

Closed
wants to merge 10 commits into from
Closed

[MWCore] Support P2P #2810

wants to merge 10 commits into from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Oct 11, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Enable support of the latest P2P features for MWCore

waiting on #2807

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (ab836af) 67.6% compared to head (02f45ab) 67.6%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2810     +/-   ##
==============================================
- Coverage          67.6%   67.6%   -0.1%     
  Complexity          901     901             
==============================================
  Files               165     166      +1     
  Lines              7384    7422     +38     
  Branches           1045    1049      +4     
==============================================
+ Hits               4997    5018     +21     
- Misses             1741    1756     +15     
- Partials            646     648      +2     
Flag Coverage Δ
engine 67.6% <73.6%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gine/configuration/app/DeviceToDeviceSyncConfig.kt 0.0% <0.0%> (ø)
.../fhircore/engine/p2p/dao/P2PReceiverTransferDao.kt 89.4% <87.5%> (+6.1%) ⬆️
...hircore/engine/util/extension/ResourceExtension.kt 69.5% <83.3%> (+0.5%) ⬆️
...er/fhircore/engine/p2p/dao/P2PSenderTransferDao.kt 73.3% <65.0%> (+2.5%) ⬆️
...ster/fhircore/engine/p2p/dao/BaseP2PTransferDao.kt 71.4% <75.6%> (-23.5%) ⬇️

... and 1 file with indirect coverage changes

@LZRS LZRS added the DNM DO NOT MERGE label Oct 24, 2023
@LZRS LZRS closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE Malawi CORE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants