Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to MeasureReportRepository class #3246

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

sharon2719
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@sharon2719 sharon2719 changed the title Test measure report repository Add tests to MeasureReportRepository class May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.0%. Comparing base (ac82739) to head (77e8d7a).
Report is 101 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3246      +/-   ##
==========================================
+ Coverage     29.6%   62.0%   +32.3%     
+ Complexity     658     650       -8     
==========================================
  Files          239     143      -96     
  Lines        11204    5204    -6000     
  Branches      1948     846    -1102     
==========================================
- Hits          3323    3228      -95     
+ Misses        7447    1559    -5888     
+ Partials       434     417      -17     
Flag Coverage Δ
engine 64.9% <ø> (-1.3%) ⬇️
geowidget 18.3% <ø> (-28.9%) ⬇️
quest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 115 files with indirect coverage changes

pld
pld previously approved these changes Jun 21, 2024
@pld pld enabled auto-merge (squash) June 21, 2024 15:51
@pld pld merged commit 569cdbe into main Jun 21, 2024
5 checks passed
@pld pld deleted the test-measure-report-repository branch June 21, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants