Configure PDF Generation #3278
Merged
Configure PDF Generation #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we add some docs in this PR? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3278 +/- ##
=========================================
- Coverage 28.1% 28.1% -0.1%
- Complexity 718 719 +1
=========================================
Files 265 267 +2
Lines 12885 12948 +63
Branches 2317 2324 +7
=========================================
+ Hits 3630 3641 +11
- Misses 8778 8827 +49
- Partials 477 480 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FikriMilano
force-pushed
the
3235-configure-pdf-generation
branch
from
c332737
to
dc1484e
Compare
|
Remaining todos:
|
|
For some reason, codecov does not detect the coverage from roboelectric test, in this case for: PdfLauncherFragment. |
@ndegwamartin do you have comments on this? |
|
The same issue might also happen on main, the coverage went from 60% to 28% |
|
Codecov shows only minimal coverage for that class on your PR , see - PR 3278 on CodeCov @fikri when you run the |
|
@FikriMilano here's the command that CI runs: ./gradlew clean :quest:fhircoreJacocoReport --stacktrace -Pandroid.testInstrumentationRunnerArguments.notPackage=org.smartregister.fhircore.quest.performance |
|
@ndegwamartin after running the command, the terminal gave me these, not sure what it means. |
@FikriMilano I think is just a warning. Did you inspect the generated HTML coverage report and determine whether it has(or doesn't have) the code coverage? |
|
@ndegwamartin here's the coverage from my local jacoco. We can say that it's not covering the PdfLauncherFragment by much. Is my test the problem or is it jacoco? Btw, we have all tests as 
|
|
@FikriMilano could you click on the PdfLauncherFragment class link on the report. Maybe screenshot that as well? |
|
@ndegwamartin here's the screenshots (my test logs was able to reach line 108, starting from onCreate): |
|
Yeah so according to Jacoco the |
|
The IDE also has a Run test with Coverage feature, when you run that, does it report approximately the same coverage for your branch ? 
|
|
The coverage is 0%. Also, If I run it that way, the test fails and gives this exception. 
|
|
As discussed w @ndegwamartin So, we'll merge this PR first, then fix the jacoco test report issue in a different PR. cc @pld |
|
Sounds good let's merge once passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3235
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile