-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Hot Fix : Correctly append PlanDefinition reference in CarePlan #3385
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
=======================================
Coverage 28.2% 28.3%
- Complexity 713 716 +3
=======================================
Files 266 266
Lines 12737 12760 +23
Branches 2264 2265 +1
=======================================
+ Hits 3603 3621 +18
- Misses 8661 8666 +5
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirCarePlanGenerator.kt
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirCarePlanGenerator.kt
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirCarePlanGenerator.kt
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirCarePlanGenerator.kt
Outdated
Show resolved
Hide resolved
Also in line with the internal conversation we can mark this method here with with the Line 171 in 70a8bc1
You can add this: @Deprecated(
message = "This function is deprecated, use workflowCarePlanGenerator.applyPlanDefinitionOnPatient() instead",
replaceWith = ReplaceWith("workflowCarePlanGenerator.applyPlanDefinitionOnPatient()"),
level = DeprecationLevel.WARNING
)
private suspend fun liteApplyPlanDefinitionOnPatient( ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved comments from PR rewview
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3383
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file