Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Hot Fix : Correctly append PlanDefinition reference in CarePlan #3385

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

f-odhiambo
Copy link
Contributor

@f-odhiambo f-odhiambo commented Jul 17, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3383

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@f-odhiambo f-odhiambo changed the title [🔧 Hot Fix] Fix adding correct reference to CarePlan for the PlanDefinition 🔧 Hot Fix : Correctly append PlanDefinition reference in CarePlan Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.3%. Comparing base (5d5454b) to head (be6aeeb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3385   +/-   ##
=======================================
  Coverage     28.2%   28.3%           
- Complexity     713     716    +3     
=======================================
  Files          266     266           
  Lines        12737   12760   +23     
  Branches      2264    2265    +1     
=======================================
+ Hits          3603    3621   +18     
- Misses        8661    8666    +5     
  Partials       473     473           
Flag Coverage Δ
engine 65.0% <75.8%> (+<0.1%) ⬆️
geowidget 19.8% <ø> (ø)
quest 4.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt 78.1% <75.8%> (+<0.1%) ⬆️

@ndegwamartin
Copy link
Contributor

Also in line with the internal conversation we can mark this method here with with the @Deprecated annotation cc @pld

You can add this:

  @Deprecated(
    message = "This function is deprecated, use workflowCarePlanGenerator.applyPlanDefinitionOnPatient() instead",
    replaceWith = ReplaceWith("workflowCarePlanGenerator.applyPlanDefinitionOnPatient()"),
    level = DeprecationLevel.WARNING
  )
  private suspend fun liteApplyPlanDefinitionOnPatient( ...

Copy link
Contributor Author

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved comments from PR rewview

android/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
@f-odhiambo f-odhiambo added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@qiarie qiarie added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@qiarie qiarie enabled auto-merge July 17, 2024 16:22
@qiarie qiarie added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 83595aa Jul 17, 2024
5 checks passed
@qiarie qiarie deleted the careplan-generation-hotfix branch July 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FHIR CarePlan generator not appending
5 participants