Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing.md #588

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Update contributing.md #588

merged 3 commits into from
Sep 30, 2021

Conversation

ndegwamartin
Copy link
Contributor

@ndegwamartin ndegwamartin commented Sep 30, 2021

Update the developer contribution

Fixes #565

Type
Choose one: Documentation

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

Update the developer contribution
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #588 (32fe1fe) into main (7f4c569) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #588   +/-   ##
=========================================
  Coverage     35.14%   35.14%           
  Complexity      339      339           
=========================================
  Files           130      130           
  Lines          3594     3594           
  Branches        506      506           
=========================================
  Hits           1263     1263           
  Misses         2189     2189           
  Partials        142      142           
Flag Coverage Δ
anc 53.16% <ø> (ø)
eir 59.08% <ø> (ø)
engine 11.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4c569...32fe1fe. Read the comment docs.

- Add recommendations for making good commits
@ndegwamartin ndegwamartin merged commit 840bb4d into main Sep 30, 2021
@ndegwamartin ndegwamartin deleted the ndegwamartin-patch-1 branch September 30, 2021 18:28
@pld pld mentioned this pull request Jan 21, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codebase documentation
2 participants