-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinGW 8.1.0 Dynamic Build install_runtime_libs fails #7653
Comments
Would you mind giving us the output of |
This may very well be about your configuration settings. Does |
That would be weird. Configuration Parameters have not changed since 1.1.1 Stable Release. But it is possible I have (mis)read a Comment in a Change(s) after the Release. Here is the dump:
|
is an empty Directory which gets created during "Install" of OpenSSL - like always. Same goes for the Static builds. BTW: The File
exists in the Out-Of-Source Directory. |
Ah, I think I've found it. Would you mind trying the following patch? diff --git a/Configurations/unix-Makefile.tmpl b/Configurations/unix-Makefile.tmpl
index 8b4b6fe3e2..c64c154939 100644
--- a/Configurations/unix-Makefile.tmpl
+++ b/Configurations/unix-Makefile.tmpl
@@ -644,7 +644,9 @@ install_runtime_libs: build_libs
@[ -n "$(INSTALLTOP)" ] || (echo INSTALLTOP should not be empty; exit 1)
@ : {- output_off() if windowsdll(); "" -}
@$(PERL) $(SRCDIR)/util/mkdir-p.pl $(DESTDIR)$(libdir)
- @ : {- output_on() if windowsdll(); "" -}
+ @ : {- output_on() if windowsdll(); output_off() unless windowsdll(); "" -}
+ @$(PERL) $(SRCDIR)/util/mkdir-p.pl $(DESTDIR)$(INSTALLTOP)/bin
+ @ : {- output_on() unless windowsdll(); "" -}
@$(ECHO) "*** Installing runtime libraries"
@set -e; for s in dummy $(INSTALL_SHLIBS); do \
if [ "$$s" = "dummy" ]; then continue; fi; \ |
Mingw and Cygwin builds install the DLLs in the application directory, not the library directory, so ensure that one is created for them when installing the DLLs. Fixes openssl#7653
|
Thank for reminding me about the need to backfit it to 1.1.1. Now done. |
Hi. It seems someone broke it again:
This is with OpenSSL 1.1.1-stable latest HEAD. Same MinGW Compiler, same config etc. etc. |
This time, I think it's you. Back in November, you configured with |
Ouch. You are right. Changing it back from '' to '/' fixed it. Guess I was lucky that it worked from December 2018 until the end of last week. Sorry for the noise! Mea Culpa! Have a sunny week :) |
Building OpenSSL 1.1.0j with mingw-w64 fails unless we patch the makefile on the fly. The patch will not apply cleanly to OpenSSL 1.1.1, so documentation was added to make note of it, as well as for the openvpn-build patch management system in general. URL: openssl/openssl#7653 Signed-off-by: Samuli Seppänen <samuli@openvpn.net>
This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653
This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653
* openssl: create 3.x.x directory * openssl/3.x.x: Update license to Apache-2.0 * openssl/3.x.x: Update reporting issues URL * openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options * openssl/3.x.x: Delete patch for 1.1.1 * openssl/3.x.x: Update option from no_zlib to zlib * openssl/3.x.x: Remove removed options no_md2 and no_rc5 * openssl/3.x.x.: no_rc4 is still a valid option https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm * openssl/3.x.x: Remove legacy target names * openssl/3.x.x.: Remove more legacy conditions * openssl/3.x.x: Fix zlib option name * Revert "openssl/3.x.x: Update license to Apache-2.0" This reverts commit 13852ab1da9678d3700440bee862561af7878b37. * openssl/3.x.x: Actually update license to Apache-2.0 * openssl/3.x.x.: Remove all legacy version switches * openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version * openssl/3.x.x.: update test_package to never use find_package() Several reasons for this decision: 1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file 2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error 3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?) 4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless * openssl/3.x.x.: Remove custom OpenSSLVersion object * openssl/3.x.x.: Remove legacy target_prefix * openssl/3.x.x.: Remove custom _cross_building method Since tools.cross_building() has now a skip_x64_x86 flag * openssl/3.x.x: Some formatting * openssl/3.x.x: Remove old workaround for MinGW This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653 * openssl/3.x.x: add no_engine option * openssl/3.x.x: Add 3.0.0-alpha5 * openssl/3.x.x: Port #1782 from @syoliver - add components * openssl/3.x.x: Fix license test The LICENSE file got renamed to LICENSE.txt * openssl/3.x.x: add old/ URLs as mirrors * openssl/3.x.x: threat URLs explicit as strings * openssl/3.x.x: add 3.0.0-alpha6 * openssl/3.x.x: the downloads have permament locations now This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions It also does not seem to apply for pre-release versions, which rather seem to get de-published See also here: openssl/openssl#4469 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.26.0 * openssl/3.x.x: reorder methods * openssl/3.x.x: add 3.0.0-alpha7 * openssl/3.x.x: test upstream PR 13225 openssl/openssl#13225 * openssl/3.x.x: update patch from upstream PR13225 * openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds * openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino * openssl/3.x.x: add 3.0.0-alpha8 * openssl/3.x.x: remove fPIC when shared Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha9 * openssl/3.x.x: use get_safe for fPIC * openssl/3.x.x: don't use get_safe for zlib option Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha10 * openssl/3.x.x: add openssl/3.0.0-alpha11 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.2 * openssl/3.x.x: add openssl/3.0.0 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.5 * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: replace os.rename -> tools.rename * opeensl/3.x.x.: nit Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: readd old versions to config.yml Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: remove platform import Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: fix typo in option name * openssl/3.x.x: more tools modernizations * openssl/3.x.x: use textwrap Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: remove MD5 and SHA1 from test_package * openssl/3.x.x: use self.options.get_safe() * openssl: add openssl.pc + fix libdir * openssl: convert test to pure C source * openssl: use spaces in test source * openssl/3.x.x: remove SSL_library_init from test_package * openssl: run openssl binary in test package * openssl: digest.c only needs crypto library * openssl: remove unused definitions for cmake * openssl: enable fPIC when not enabled + use zlib's shared option correctly * openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times * openssl: tools.XCRun only acceps Settings object * openssl: use self.settings.os * openssl: reformatting + be the first to use f-strings + functools.lru_cache * openssl: ./Configure --help does not print any targets. * openssl: fix critical typo * openssl: fix sneaky usage of tools.os_info in build_requirements * openssl/3.x.x: remove patch for macOS shared Co-Authored-By: Bowb <bowb@users.noreply.github.com> * openssl/3.x.x: port #4460 remove explicit apple deployment target flag Co-Authored-By: SSE4 <tomskside@gmail.com> * openssl/3.x.x: port #4597 provide official variables in cmake_find_package Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #4698 fix rt dependency for SUSE11 Co-Authored-By: Alexey Klimkin <klimkin@gmail.com> * openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #5441 closes #4740 Co-Authored-By: Dmitry Bely <db4@users.noreply.github.com> * openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS Co-Authored-By: Arenoros <arenoros@users.noreply.github.com> * openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support Co-Authored-By: Stefan Floeren <stefan-floeren@users.noreply.github.com> * openssl/3.x.x: port #6588 Add macOS ARM target Co-Authored-By: gmeeker <gmeeker@users.noreply.github.com> * openssl/3.x.x: port #6884 Build openssl for emscripten Co-Authored-By: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> * openssl: reformatting fixes * openssl: make method property + remove unused import * openssl: reverse sort openssl's config.yml * openssl: only run openssl when not cross building * openssl: port options of openssl 1.1.1 * openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False * force push Signed-off-by: Uilian Ries <uilianries@gmail.com> * openssl: add missing options + various reformatting Co-authored-by: bincrafters-user <bincrafters@gmail.com> Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Co-authored-by: Anonymous Maarten <anonymous.maarten@gmail.com> Co-authored-by: Bowb <bowb@users.noreply.github.com> Co-authored-by: SSE4 <tomskside@gmail.com> Co-authored-by: SpaceIm <spaceim@users.noreply.github.com> Co-authored-by: Alexey Klimkin <klimkin@gmail.com> Co-authored-by: Dmitry Bely <db4@users.noreply.github.com> Co-authored-by: Arenoros <arenoros@users.noreply.github.com> Co-authored-by: Stefan Floeren <stefan-floeren@users.noreply.github.com> Co-authored-by: gmeeker <gmeeker@users.noreply.github.com> Co-authored-by: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
The Error is (from mingw32-make -d):
The text was updated successfully, but these errors were encountered: