openssl: fix rt dependency for SUSE11 #4698

klimkin · 2021-02-26T21:09:55Z

openssl::crypto uses clock_gettime() that requires -lrt on SUSE.

Specify library name and version: openssl/1.1.1i

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

openssl::crypto uses clock_gettime() that requires `-lrt` on SUSE.

ghost · 2021-02-26T21:10:16Z

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2021-02-27T01:08:27Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2021-02-27T12:32:22Z

All green in build 2 (454c02c2a9c5a16c8426f85d0363c24fed8c1a14)! 😊

openssl/1.0.2s: Generated 104 packages. All logs here
openssl/1.0.2t: Generated 104 packages. All logs here
openssl/1.0.2u: Generated 104 packages. All logs here
openssl/1.1.0k: Generated 104 packages. All logs here
openssl/1.1.0l: Generated 104 packages. All logs here
openssl/1.1.1c: Generated 104 packages. All logs here
openssl/1.1.1d: Generated 104 packages. All logs here
openssl/1.1.1e: Generated 104 packages. All logs here
openssl/1.1.1f: Generated 104 packages. All logs here
openssl/1.1.1g: Generated 104 packages. All logs here
openssl/1.1.1h: Generated 104 packages. All logs here
openssl/1.1.1i: Generated 104 packages. All logs here
openssl/1.1.1j: Generated 104 packages. All logs here

mathbunnyru · 2021-02-27T14:08:05Z

https://linux.die.net/man/3/clock_gettime

Note
Most systems require the program be linked with the librt library to use these functions.

So, I think this will also fix some other distros.

prince-chrismc · 2021-02-27T18:02:39Z

https://github.com/openssl/openssl/blob/15f54941bd4c0324f1c8d7773db56004183a9cb7/providers/implementations/rands/seeding/rand_unix.c#L204

It was added openssl/openssl@cc7399e#diff-dba8c3f61f549f95824cacc4d356df3e33e7c6db5038f8a6e5c0d2e2ad46a45aR160 Which is before 1.0.0

Hard to saw when the code is built from the UI 🤔

prince-chrismc · 2021-03-02T02:26:38Z

You'll need to retrigger CI 🔁

Commit status bug 🐛

PR	By	Recipe	Reviews	🛑 Blockers	🌟 Approvers
#4698	klimkin	⚠️ openssl	4		mathbunnyru, prince-chrismc, SSE4, uilianries

klimkin · 2021-03-02T22:24:30Z

How do you retrigger CI?

prince-chrismc · 2021-03-03T01:44:33Z

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

I am sorry, you've done lot of amazing contributions I forgot to include the instructions!

conan-center-bot · 2021-03-03T03:24:46Z

All green in build 3 (454c02c2a9c5a16c8426f85d0363c24fed8c1a14)! 😊

openssl/1.0.2s: Generated 104 packages. All logs here
openssl/1.0.2t: Generated 104 packages. All logs here
openssl/1.0.2u: Generated 104 packages. All logs here
openssl/1.1.0k: Generated 104 packages. All logs here
openssl/1.1.0l: Generated 104 packages. All logs here
openssl/1.1.1c: Generated 104 packages. All logs here
openssl/1.1.1d: Generated 104 packages. All logs here
openssl/1.1.1e: Generated 104 packages. All logs here
openssl/1.1.1f: Generated 104 packages. All logs here
openssl/1.1.1g: Generated 104 packages. All logs here
openssl/1.1.1h: Generated 104 packages. All logs here
openssl/1.1.1i: Generated 104 packages. All logs here
openssl/1.1.1j: Generated 104 packages. All logs here

prince-chrismc · 2021-03-03T14:04:55Z

@jgsogo @danimtb if you have a chance this PR is not being updated correctly by the bot. Thanks in advance

jgsogo · 2021-03-03T14:10:02Z

Yes, this is one of those errors when Github doesn't update the status (I assume it is a network issue of our CI sending the notification to Github). Merge by hand!

prince-chrismc · 2021-03-03T15:12:35Z

Thank you!

Co-Authored-By: Alexey Klimkin <klimkin@gmail.com>

@syoliver

* openssl: create 3.x.x directory * openssl/3.x.x: Update license to Apache-2.0 * openssl/3.x.x: Update reporting issues URL * openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options * openssl/3.x.x: Delete patch for 1.1.1 * openssl/3.x.x: Update option from no_zlib to zlib * openssl/3.x.x: Remove removed options no_md2 and no_rc5 * openssl/3.x.x.: no_rc4 is still a valid option https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm * openssl/3.x.x: Remove legacy target names * openssl/3.x.x.: Remove more legacy conditions * openssl/3.x.x: Fix zlib option name * Revert "openssl/3.x.x: Update license to Apache-2.0" This reverts commit 13852ab1da9678d3700440bee862561af7878b37. * openssl/3.x.x: Actually update license to Apache-2.0 * openssl/3.x.x.: Remove all legacy version switches * openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version * openssl/3.x.x.: update test_package to never use find_package() Several reasons for this decision: 1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file 2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error 3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?) 4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless * openssl/3.x.x.: Remove custom OpenSSLVersion object * openssl/3.x.x.: Remove legacy target_prefix * openssl/3.x.x.: Remove custom _cross_building method Since tools.cross_building() has now a skip_x64_x86 flag * openssl/3.x.x: Some formatting * openssl/3.x.x: Remove old workaround for MinGW This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653 * openssl/3.x.x: add no_engine option * openssl/3.x.x: Add 3.0.0-alpha5 * openssl/3.x.x: Port #1782 from @syoliver - add components * openssl/3.x.x: Fix license test The LICENSE file got renamed to LICENSE.txt * openssl/3.x.x: add old/ URLs as mirrors * openssl/3.x.x: threat URLs explicit as strings * openssl/3.x.x: add 3.0.0-alpha6 * openssl/3.x.x: the downloads have permament locations now This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions It also does not seem to apply for pre-release versions, which rather seem to get de-published See also here: openssl/openssl#4469 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.26.0 * openssl/3.x.x: reorder methods * openssl/3.x.x: add 3.0.0-alpha7 * openssl/3.x.x: test upstream PR 13225 openssl/openssl#13225 * openssl/3.x.x: update patch from upstream PR13225 * openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds * openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino * openssl/3.x.x: add 3.0.0-alpha8 * openssl/3.x.x: remove fPIC when shared Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha9 * openssl/3.x.x: use get_safe for fPIC * openssl/3.x.x: don't use get_safe for zlib option Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha10 * openssl/3.x.x: add openssl/3.0.0-alpha11 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.2 * openssl/3.x.x: add openssl/3.0.0 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.5 * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: replace os.rename -> tools.rename * opeensl/3.x.x.: nit Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: readd old versions to config.yml Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: remove platform import Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: fix typo in option name * openssl/3.x.x: more tools modernizations * openssl/3.x.x: use textwrap Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: remove MD5 and SHA1 from test_package * openssl/3.x.x: use self.options.get_safe() * openssl: add openssl.pc + fix libdir * openssl: convert test to pure C source * openssl: use spaces in test source * openssl/3.x.x: remove SSL_library_init from test_package * openssl: run openssl binary in test package * openssl: digest.c only needs crypto library * openssl: remove unused definitions for cmake * openssl: enable fPIC when not enabled + use zlib's shared option correctly * openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times * openssl: tools.XCRun only acceps Settings object * openssl: use self.settings.os * openssl: reformatting + be the first to use f-strings + functools.lru_cache * openssl: ./Configure --help does not print any targets. * openssl: fix critical typo * openssl: fix sneaky usage of tools.os_info in build_requirements * openssl/3.x.x: remove patch for macOS shared Co-Authored-By: Bowb <bowb@users.noreply.github.com> * openssl/3.x.x: port #4460 remove explicit apple deployment target flag Co-Authored-By: SSE4 <tomskside@gmail.com> * openssl/3.x.x: port #4597 provide official variables in cmake_find_package Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #4698 fix rt dependency for SUSE11 Co-Authored-By: Alexey Klimkin <klimkin@gmail.com> * openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #5441 closes #4740 Co-Authored-By: Dmitry Bely <db4@users.noreply.github.com> * openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS Co-Authored-By: Arenoros <arenoros@users.noreply.github.com> * openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support Co-Authored-By: Stefan Floeren <stefan-floeren@users.noreply.github.com> * openssl/3.x.x: port #6588 Add macOS ARM target Co-Authored-By: gmeeker <gmeeker@users.noreply.github.com> * openssl/3.x.x: port #6884 Build openssl for emscripten Co-Authored-By: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> * openssl: reformatting fixes * openssl: make method property + remove unused import * openssl: reverse sort openssl's config.yml * openssl: only run openssl when not cross building * openssl: port options of openssl 1.1.1 * openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False * force push Signed-off-by: Uilian Ries <uilianries@gmail.com> * openssl: add missing options + various reformatting Co-authored-by: bincrafters-user <bincrafters@gmail.com> Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Co-authored-by: Anonymous Maarten <anonymous.maarten@gmail.com> Co-authored-by: Bowb <bowb@users.noreply.github.com> Co-authored-by: SSE4 <tomskside@gmail.com> Co-authored-by: SpaceIm <spaceim@users.noreply.github.com> Co-authored-by: Alexey Klimkin <klimkin@gmail.com> Co-authored-by: Dmitry Bely <db4@users.noreply.github.com> Co-authored-by: Arenoros <arenoros@users.noreply.github.com> Co-authored-by: Stefan Floeren <stefan-floeren@users.noreply.github.com> Co-authored-by: gmeeker <gmeeker@users.noreply.github.com> Co-authored-by: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

openssl: fix rt dependency for SUSE11

454c02c

openssl::crypto uses clock_gettime() that requires `-lrt` on SUSE.

This was referenced Feb 26, 2021

[service] Potentially conflicting recipes #3571

Closed

add libatomic in build dependency for Neutrino OS #3998

Merged

github-actions bot mentioned this pull request Feb 26, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Unexpected Error label Feb 27, 2021

conan-center-bot removed the Unexpected Error label Feb 27, 2021

mathbunnyru approved these changes Feb 27, 2021

View reviewed changes

prince-chrismc approved these changes Feb 27, 2021

View reviewed changes

SSE4 approved these changes Mar 1, 2021

View reviewed changes

ghost mentioned this pull request Mar 1, 2021

(#3476) OpenSSL: change default openssldir value on Linux #4742

Merged

4 tasks

uilianries approved these changes Mar 1, 2021

View reviewed changes

klimkin closed this Mar 3, 2021

klimkin reopened this Mar 3, 2021

jgsogo merged commit 356c30c into conan-io:master Mar 3, 2021

klimkin deleted the hotfix/openssl-rt-dependency branch March 9, 2021 01:24

Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Sep 9, 2021

openssl/3.x.x: port conan-io#4698 fix rt dependency for SUSE11

0767f32

Co-Authored-By: Alexey Klimkin <klimkin@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openssl: fix rt dependency for SUSE11 #4698

openssl: fix rt dependency for SUSE11 #4698

klimkin commented Feb 26, 2021

ghost commented Feb 26, 2021 •

edited by ghost

Loading

conan-center-bot commented Feb 27, 2021

conan-center-bot commented Feb 27, 2021

mathbunnyru commented Feb 27, 2021

prince-chrismc commented Feb 27, 2021

prince-chrismc commented Mar 2, 2021

klimkin commented Mar 2, 2021

prince-chrismc commented Mar 3, 2021

conan-center-bot commented Mar 3, 2021

prince-chrismc commented Mar 3, 2021

jgsogo commented Mar 3, 2021

prince-chrismc commented Mar 3, 2021

openssl: fix rt dependency for SUSE11 #4698

openssl: fix rt dependency for SUSE11 #4698

Conversation

klimkin commented Feb 26, 2021

ghost commented Feb 26, 2021 • edited by ghost Loading

conan-center-bot commented Feb 27, 2021

conan-center-bot commented Feb 27, 2021

mathbunnyru commented Feb 27, 2021

prince-chrismc commented Feb 27, 2021

prince-chrismc commented Mar 2, 2021

klimkin commented Mar 2, 2021

prince-chrismc commented Mar 3, 2021

conan-center-bot commented Mar 3, 2021

prince-chrismc commented Mar 3, 2021

jgsogo commented Mar 3, 2021

prince-chrismc commented Mar 3, 2021

ghost commented Feb 26, 2021 •

edited by ghost

Loading