[openssl/1.1.1k] Add macOS ARM target #6588

gmeeker · 2021-07-29T20:05:42Z

OpenSSL's darwin64-arm64-cc is available since 1.1.1i and is necessary to enable assembly code support.

openssl/1.1.1k (also tested 1.1.1h, 1.1.1i). Also patch 1.0.2 to compile ARM (without assembly optimizations).

Built with the following profile:
[settings]
os=Macos
os_build=Macos
os.version=11.0
arch=armv8
arch_build=armv8
compiler=apple-clang
compiler.version=12.0
compiler.libcxx=libc++
build_type=Release
compiler.cppstd=11
[options]
[build_requires]
[env]

[ x] I've read the guidelines for contributing.
[ x] I've followed the PEP8 style guides for Python code in the recipes.
[ x] I've used the latest Conan client version.
[ x] I've tried at least one configuration locally with the
conan-center hook activated.

darwin64-arm64-cc is available since 1.1.1i and is necessary to enable assembly code support.

CLAassistant · 2021-07-29T20:05:49Z

All committers have signed the CLA.

gmeeker · 2021-08-09T17:08:15Z

Fixes #6788

madebr · 2021-08-09T22:23:48Z

recipes/openssl/1.x.x/conanfile.py

@@ -329,6 +330,7 @@ def _targets(self):
            "Macos-ppc32be-*": "%sdarwin-ppc-cc" % self._target_prefix,
            "Macos-ppc64-*": "darwin64-ppc-cc",
            "Macos-ppc64be-*": "darwin64-ppc-cc",
+            "Macos-armv8-*": "darwin64-arm64-cc" if has_darwin_arm else "darwin-common",


@SpaceIm
I think you have an ARM Apple.
Can you verify this pr?

Nop, Apple Intel. I can test cross-build to Apple M1 like CI already does.

madebr · 2021-08-09T22:26:20Z

@gmeeker
You can trigger a build by closing/re-opening this pr.
This doesn't happen automatically.

Also, Please add Fixes #6788 to your initial message.
Then, github will automatically close your issue when this pr gets merged.

conan-center-bot · 2021-08-10T03:03:49Z

All green in build 4 (646b23477054188fe3007ab6960e80bed08143ea):

openssl/1.0.2t@:
All packages built successfully! (All logs)
openssl/1.0.2u@:
All packages built successfully! (All logs)
openssl/1.1.0k@:
All packages built successfully! (All logs)
openssl/1.1.0l@:
All packages built successfully! (All logs)
openssl/1.0.2s@:
All packages built successfully! (All logs)
openssl/1.1.1d@:
All packages built successfully! (All logs)
openssl/1.1.1k@:
All packages built successfully! (All logs)
openssl/1.1.1c@:
All packages built successfully! (All logs)
openssl/1.1.1e@:
All packages built successfully! (All logs)
openssl/1.1.1f@:
All packages built successfully! (All logs)
openssl/1.1.1h@:
All packages built successfully! (All logs)
openssl/1.1.1i@:
All packages built successfully! (All logs)
openssl/1.1.1g@:
All packages built successfully! (All logs)
openssl/1.1.1j@:
All packages built successfully! (All logs)

SSE4

yes, we need it, many recipes depend on OpenSSL, and fail because of missing M1 packages

SpaceIm · 2021-08-26T00:04:10Z

recipes/openssl/1.x.x/conanfile.py

+                    if self.settings.os == "Macos":
+                        tools.patch(patch_file=os.path.join("patches", "1.0.2u-darwin-arm64.patch"),
+                                    base_path=self._source_subfolder)


Maybe it should be moved to conanfile.yml, since this patch is fine for all settings. This conanfile is already hard to understand.

Co-Authored-By: gmeeker <gmeeker@users.noreply.github.com>

@syoliver

* openssl: create 3.x.x directory * openssl/3.x.x: Update license to Apache-2.0 * openssl/3.x.x: Update reporting issues URL * openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options * openssl/3.x.x: Delete patch for 1.1.1 * openssl/3.x.x: Update option from no_zlib to zlib * openssl/3.x.x: Remove removed options no_md2 and no_rc5 * openssl/3.x.x.: no_rc4 is still a valid option https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm * openssl/3.x.x: Remove legacy target names * openssl/3.x.x.: Remove more legacy conditions * openssl/3.x.x: Fix zlib option name * Revert "openssl/3.x.x: Update license to Apache-2.0" This reverts commit 13852ab1da9678d3700440bee862561af7878b37. * openssl/3.x.x: Actually update license to Apache-2.0 * openssl/3.x.x.: Remove all legacy version switches * openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version * openssl/3.x.x.: update test_package to never use find_package() Several reasons for this decision: 1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file 2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error 3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?) 4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless * openssl/3.x.x.: Remove custom OpenSSLVersion object * openssl/3.x.x.: Remove legacy target_prefix * openssl/3.x.x.: Remove custom _cross_building method Since tools.cross_building() has now a skip_x64_x86 flag * openssl/3.x.x: Some formatting * openssl/3.x.x: Remove old workaround for MinGW This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653 * openssl/3.x.x: add no_engine option * openssl/3.x.x: Add 3.0.0-alpha5 * openssl/3.x.x: Port #1782 from @syoliver - add components * openssl/3.x.x: Fix license test The LICENSE file got renamed to LICENSE.txt * openssl/3.x.x: add old/ URLs as mirrors * openssl/3.x.x: threat URLs explicit as strings * openssl/3.x.x: add 3.0.0-alpha6 * openssl/3.x.x: the downloads have permament locations now This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions It also does not seem to apply for pre-release versions, which rather seem to get de-published See also here: openssl/openssl#4469 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.26.0 * openssl/3.x.x: reorder methods * openssl/3.x.x: add 3.0.0-alpha7 * openssl/3.x.x: test upstream PR 13225 openssl/openssl#13225 * openssl/3.x.x: update patch from upstream PR13225 * openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds * openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino * openssl/3.x.x: add 3.0.0-alpha8 * openssl/3.x.x: remove fPIC when shared Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha9 * openssl/3.x.x: use get_safe for fPIC * openssl/3.x.x: don't use get_safe for zlib option Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: add 3.0.0-alpha10 * openssl/3.x.x: add openssl/3.0.0-alpha11 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.2 * openssl/3.x.x: add openssl/3.0.0 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.5 * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: replace os.rename -> tools.rename * opeensl/3.x.x.: nit Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: readd old versions to config.yml Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com> * openssl/3.x.x: remove platform import Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: fix typo in option name * openssl/3.x.x: more tools modernizations * openssl/3.x.x: use textwrap Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * openssl/3.x.x: remove MD5 and SHA1 from test_package * openssl/3.x.x: use self.options.get_safe() * openssl: add openssl.pc + fix libdir * openssl: convert test to pure C source * openssl: use spaces in test source * openssl/3.x.x: remove SSL_library_init from test_package * openssl: run openssl binary in test package * openssl: digest.c only needs crypto library * openssl: remove unused definitions for cmake * openssl: enable fPIC when not enabled + use zlib's shared option correctly * openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times * openssl: tools.XCRun only acceps Settings object * openssl: use self.settings.os * openssl: reformatting + be the first to use f-strings + functools.lru_cache * openssl: ./Configure --help does not print any targets. * openssl: fix critical typo * openssl: fix sneaky usage of tools.os_info in build_requirements * openssl/3.x.x: remove patch for macOS shared Co-Authored-By: Bowb <bowb@users.noreply.github.com> * openssl/3.x.x: port #4460 remove explicit apple deployment target flag Co-Authored-By: SSE4 <tomskside@gmail.com> * openssl/3.x.x: port #4597 provide official variables in cmake_find_package Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #4698 fix rt dependency for SUSE11 Co-Authored-By: Alexey Klimkin <klimkin@gmail.com> * openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only Co-Authored-By: SpaceIm <spaceim@users.noreply.github.com> * openssl/3.x.x: port #5441 closes #4740 Co-Authored-By: Dmitry Bely <db4@users.noreply.github.com> * openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS Co-Authored-By: Arenoros <arenoros@users.noreply.github.com> * openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support Co-Authored-By: Stefan Floeren <stefan-floeren@users.noreply.github.com> * openssl/3.x.x: port #6588 Add macOS ARM target Co-Authored-By: gmeeker <gmeeker@users.noreply.github.com> * openssl/3.x.x: port #6884 Build openssl for emscripten Co-Authored-By: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> * openssl: reformatting fixes * openssl: make method property + remove unused import * openssl: reverse sort openssl's config.yml * openssl: only run openssl when not cross building * openssl: port options of openssl 1.1.1 * openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False * force push Signed-off-by: Uilian Ries <uilianries@gmail.com> * openssl: add missing options + various reformatting Co-authored-by: bincrafters-user <bincrafters@gmail.com> Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Co-authored-by: Anonymous Maarten <anonymous.maarten@gmail.com> Co-authored-by: Bowb <bowb@users.noreply.github.com> Co-authored-by: SSE4 <tomskside@gmail.com> Co-authored-by: SpaceIm <spaceim@users.noreply.github.com> Co-authored-by: Alexey Klimkin <klimkin@gmail.com> Co-authored-by: Dmitry Bely <db4@users.noreply.github.com> Co-authored-by: Arenoros <arenoros@users.noreply.github.com> Co-authored-by: Stefan Floeren <stefan-floeren@users.noreply.github.com> Co-authored-by: gmeeker <gmeeker@users.noreply.github.com> Co-authored-by: Volodymyr B. <3d4m-vladimir@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

Add macOS ARM target

c581086

darwin64-arm64-cc is available since 1.1.1i and is necessary to enable assembly code support.

This comment has been minimized.

Sign in to view

conan-center-bot added the No Beta user label Jul 29, 2021

Adding patch to compile openssl 1.0.2 for macOS ARM

646b234

conan-center-bot removed the No Beta user label Aug 9, 2021

github-actions bot mentioned this pull request Aug 9, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

madebr reviewed Aug 9, 2021

View reviewed changes

gmeeker closed this Aug 9, 2021

gmeeker reopened this Aug 9, 2021

SSE4 requested a review from uilianries August 10, 2021 14:36

SSE4 approved these changes Aug 10, 2021

View reviewed changes

madebr approved these changes Aug 10, 2021

View reviewed changes

uilianries approved these changes Aug 11, 2021

View reviewed changes

conan-center-bot merged commit 8d8c06b into conan-io:master Aug 11, 2021

jgsogo mentioned this pull request Aug 12, 2021

add msix/1.7 #6475

Merged

4 tasks

SpaceIm reviewed Aug 26, 2021

View reviewed changes

Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Sep 9, 2021

openssl/3.x.x: port conan-io#6588 Add macOS ARM target

bf9818f

Co-Authored-By: gmeeker <gmeeker@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[openssl/1.1.1k] Add macOS ARM target #6588

[openssl/1.1.1k] Add macOS ARM target #6588

gmeeker commented Jul 29, 2021 •

edited

Loading

CLAassistant commented Jul 29, 2021 •

edited

Loading

This comment has been minimized.

gmeeker commented Aug 9, 2021

madebr Aug 9, 2021

SpaceIm Aug 9, 2021

madebr commented Aug 9, 2021

conan-center-bot commented Aug 10, 2021

SSE4 left a comment

SpaceIm Aug 26, 2021 •

edited

Loading

[openssl/1.1.1k] Add macOS ARM target #6588

[openssl/1.1.1k] Add macOS ARM target #6588

Conversation

gmeeker commented Jul 29, 2021 • edited Loading

CLAassistant commented Jul 29, 2021 • edited Loading

This comment has been minimized.

gmeeker commented Aug 9, 2021

madebr Aug 9, 2021

Choose a reason for hiding this comment

SpaceIm Aug 9, 2021

Choose a reason for hiding this comment

madebr commented Aug 9, 2021

conan-center-bot commented Aug 10, 2021

SSE4 left a comment

Choose a reason for hiding this comment

SpaceIm Aug 26, 2021 • edited Loading

Choose a reason for hiding this comment

gmeeker commented Jul 29, 2021 •

edited

Loading

CLAassistant commented Jul 29, 2021 •

edited

Loading

SpaceIm Aug 26, 2021 •

edited

Loading