Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Step Key Derivation #8230

Closed
wants to merge 2 commits into from
Closed

Single Step Key Derivation #8230

wants to merge 2 commits into from

Conversation

slontis
Copy link
Member

@slontis slontis commented Feb 14, 2019 •
edited
Loading

Also known as 'One Step Key Derivation' as defined in NIST SP800-56C-r1
This offers an alternative method to 'extract and expand' for key agreement purposes.
NOTE: this will probably replace ecdh_KDF_X9_63 in ecdh_kdf.c (which is basically the Single step H(x)=Hash)

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis
Copy link
Member Author

slontis commented Feb 14, 2019

NOTE: There is a lack of approved test vectors (NIST) currently for this implementation. This is the reason the KMAC implementation is currenty enabled via a #define

levitte
levitte requested changes Feb 14, 2019
View reviewed changes
doc/man7/EVP_KDF_SS.pod Outdated Show resolved Hide resolved
doc/man7/EVP_KDF_SS.pod Outdated Show resolved Hide resolved
doc/man7/EVP_KDF_SS.pod Outdated Show resolved Hide resolved
doc/man7/EVP_KDF_SS.pod Show resolved Hide resolved
@levitte levitte mentioned this pull request Feb 14, 2019
Closed
2 tasks
mattcaswell
mattcaswell requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably do with a CHANGES entry

crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
crypto/kdf/sskdf.c Show resolved Hide resolved
crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
doc/man3/EVP_KDF_CTX.pod Show resolved Hide resolved
doc/man3/EVP_KDF_CTX.pod Show resolved Hide resolved
doc/man7/EVP_KDF_SS.pod Outdated Show resolved Hide resolved
doc/man7/EVP_KDF_SS.pod Show resolved Hide resolved
doc/man7/EVP_KDF_SS.pod Outdated Show resolved Hide resolved
@slontis slontis force-pushed the kdf_singlestep branch 4 times, most recently from b7f3ae3 to a142002 Compare February 20, 2019 04:52
@slontis
Copy link
Member Author

slontis commented Mar 4, 2019

ping
Rebased to fix merge conflicts.

mattcaswell
mattcaswell requested changes Mar 5, 2019
View reviewed changes
crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
crypto/kdf/sskdf.c Show resolved Hide resolved
@slontis slontis force-pushed the kdf_singlestep branch 2 times, most recently from c4095fc to 917f7c7 Compare March 11, 2019 04:47
@slontis
Copy link
Member Author

slontis commented Mar 11, 2019

ping Added a few tweaks to the code.

@mattcaswell mattcaswell added the approval: review pending This pull request needs review by a committer label Mar 11, 2019
@mattcaswell
Copy link
Member

Ping @levitte for second review

@slontis
Copy link
Member Author

slontis commented Mar 13, 2019

ping @levitte.
Can you review please, I will rebase the generated files

@slontis
Copy link
Member Author

slontis commented Mar 18, 2019

ping

paulidale
paulidale reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about the KMAC #if and a wording in the documentation.

doc/man7/EVP_KDF_SS.pod Show resolved Hide resolved
crypto/kdf/sskdf.c Outdated Show resolved Hide resolved
levitte
levitte reviewed Mar 18, 2019
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit, but also a question of style

crypto/kdf/sskdf.c Show resolved Hide resolved
@paulidale paulidale added approval: done This pull request has the required number of approvals branch: master Merge to master branch labels Mar 19, 2019
@paulidale paulidale removed the approval: review pending This pull request needs review by a committer label Mar 19, 2019
@patrickfav patrickfav mentioned this pull request Mar 19, 2019
Open
@mattcaswell
Copy link
Member

I squashed and pushed.

levitte pushed a commit that referenced this pull request Mar 19, 2019
@slontis @mattcaswell
Single step kdf implementation
9537fe5 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #8230)
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 22, 2021
@slontis @hustliyilin
Single step kdf implementation
3b0179f 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 25, 2021
@slontis @hustliyilin
Single step kdf implementation
e5d4a7d 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 25, 2021
@hustliyilin
Single step kdf implementation
8a53f2a 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 26, 2021
@slontis @hustliyilin
Single step kdf implementation
ecacb13 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 27, 2021
@slontis @hustliyilin
Single step kdf implementation
8ac1d42 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 28, 2021
@slontis @hustliyilin
Single step kdf implementation
671e2a7 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 28, 2021
@slontis @hustliyilin
Single step kdf implementation
d64ef9c 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 28, 2021
@slontis @hustliyilin
Single step kdf implementation
c7553eb 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
hustliyilin pushed a commit to hustliyilin/BabaSSL that referenced this pull request Oct 28, 2021
@slontis @hustliyilin
Single step kdf implementation
bd1190a 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
uudiin pushed a commit to Tongsuo-Project/Tongsuo that referenced this pull request Oct 30, 2021
@slontis @uudiin
Single step kdf implementation
80c880b 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#8230)

(cherry picked from commit 9537fe5757bb07761fa275d779bbd40bcf5530e4)
[Yilin: rebase babassl master]

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte requested changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slontis @mattcaswell @levitte @paulidale