Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clacheck/clacheck.py: Make trivial commits more visible #49

Closed
wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Dec 13, 2019

If any trivial commit is found, make sure to add a label for it.

This required some major rework to separate status reporting from
label manipulation.

If any trivial commit is found, make sure to add a label for it.

This required some major rework to separate status reporting from
label manipulation.
@levitte
Copy link
Member Author

levitte commented Dec 13, 2019

@richsalz, how did you go about debugging these without them running live?

@mspncp
Copy link
Contributor

mspncp commented Dec 13, 2019

Note: for your convenience I created the required label:

image

@paulidale
Copy link
Contributor

Spawn a new test repo and experiment away?

@richsalz
Copy link
Contributor

I used to run it live on the repo. Once it was working, I only had to do it one more time. You can replay previous transactions and examine the log; I don't recall the details.

@levitte
Copy link
Member Author

levitte commented Mar 11, 2020

So @iamamoose, did you basically approve this with your comment in #63? (#63 (comment))

@levitte
Copy link
Member Author

levitte commented Mar 11, 2020

I just realised that I can use openssl/openssl#11257 to experiment with this change

@iamamoose
Copy link
Member

So @iamamoose, did you basically approve this with your comment in #63? (#63 (comment))

no, i've not tested it or reviewed it

@levitte
Copy link
Member Author

levitte commented Apr 23, 2020

I'll move this to https://github.com/openssl/omc-tools

@t8m
Copy link
Member

t8m commented Apr 28, 2021

No longer relevant

@t8m t8m closed this Apr 28, 2021
@levitte levitte deleted the trivial-label branch April 28, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants