Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable libvirt TLS but not NBD TLS #617

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Apr 9, 2024

Related: OSPRH-2387

@openshift-ci openshift-ci bot requested review from rebtoor and viroel April 9, 2024 07:39
@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
@olliewalsh
Copy link
Contributor Author

/hold

olliewalsh added a commit to olliewalsh/openstack-operator that referenced this pull request Apr 9, 2024
olliewalsh added a commit to olliewalsh/openstack-operator that referenced this pull request Apr 9, 2024
@olliewalsh olliewalsh requested a review from stuggi April 11, 2024 08:16
@olliewalsh
Copy link
Contributor Author

/remove-hold

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh olliewalsh merged commit cf30d14 into openstack-k8s-operators:main Apr 11, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants