Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TLS-e by default #727

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Enable TLS-e by default #727

merged 1 commit into from
Apr 9, 2024

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Mar 28, 2024 •
edited
Loading

As there is no longer an external dependency, TLS-e can now be enabled by default (with explicit opt-out e.g for adoption).

Depends-On: openstack-k8s-operators/edpm-ansible#613

Related: OSPRH-2038

@olliewalsh
Copy link
Contributor Author

/hold

@olliewalsh
Copy link
Contributor Author

/retest crc_storage error

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@olliewalsh: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test functional
  • /test images
  • /test openstack-operator-build-deploy
  • /test openstack-operator-build-deploy-kuttl
  • /test precommit-check

The following commands are available to trigger optional jobs:

  • /test openstack-operator-build-deploy-tempest

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openstack-k8s-operators-openstack-operator-main-functional
  • pull-ci-openstack-k8s-operators-openstack-operator-main-images
  • pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl
  • pull-ci-openstack-k8s-operators-openstack-operator-main-precommit-check

In response to this:

/retest crc_storage error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olliewalsh
Copy link
Contributor Author

/retest

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/dataplane-operator#754 is needed.

@olliewalsh
Copy link
Contributor Author

/retest

@olliewalsh
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5a0f97cd6b0f4fd7a7f683503be1cf4f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 18s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 28s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 32m 17s
❌ openstack-operator-tempest-multinode RETRY_LIMIT in 23m 11s

@olliewalsh
Copy link
Contributor Author

/retest

@stuggi
Copy link
Contributor

stuggi commented Apr 2, 2024

/test openstack-operator-build-deploy-kuttl

2 similar comments
@stuggi
Copy link
Contributor

stuggi commented Apr 2, 2024

/test openstack-operator-build-deploy-kuttl

@fao89
Copy link
Contributor

fao89 commented Apr 2, 2024

/test openstack-operator-build-deploy-kuttl

@fao89
Copy link
Contributor

fao89 commented Apr 2, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5ed213f457cf4e1a90db0993f6463f94

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 21s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 54s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 58s
❌ openstack-operator-tempest-multinode FAILURE in 1h 31m 14s

@olliewalsh
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@olliewalsh
Copy link
Contributor Author

/remove-hold

@olliewalsh
Copy link
Contributor Author

openstack-k8s-operators/dataplane-operator#754 merged and
openstack-k8s-operators/data-plane-adoption#393 to explicitly disable TLSe for adoption so should be good to merge now

@olliewalsh
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2a1a8507cd8a467bb666c2e1494b1d40

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 17s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 39s
❌ openstack-operator-tempest-multinode FAILURE in 1h 13m 02s

@fao89
Copy link
Contributor

fao89 commented Apr 3, 2024

maybe you need to update the go.mod with the latest dataplane

@olliewalsh
Copy link
Contributor Author

maybe you need to update the go.mod with the latest dataplane

yes, thought I would get CI with it from depends-on but seems not

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b01e443c174e4e25aad6330de8b2b974

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 51s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 25s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 11m 06s
❌ openstack-operator-tempest-multinode FAILURE in 1h 28m 57s

@olliewalsh
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ecc9f0fe1fdc4583b6239e277482da71

✔️ openstack-k8s-operators-content-provider SUCCESS in 40m 51s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 15m 45s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 11s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 22m 24s
❌ openstack-operator-tempest-multinode RETRY_LIMIT in 18m 28s

@fao89
Copy link
Contributor

fao89 commented Apr 6, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ba7ead04092e40c185927592f647d8f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 41m 15s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 15m 19s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 00s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 23m 09s
❌ openstack-operator-tempest-multinode RETRY_LIMIT in 18m 37s

@olliewalsh
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9e6c997e5f2d4cf19e05ebdb9ef89b66

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 57m 53s
❌ podified-multinode-edpm-deployment-crc FAILURE in 55m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 44m 04s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 39m 26s
❌ openstack-operator-tempest-multinode FAILURE in 2h 00m 01s

@olliewalsh
Copy link
Contributor Author

recheck

@olliewalsh olliewalsh mentioned this pull request Apr 8, 2024
Merged
1 task
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/864bab6b858f473fabda65c35eff162f

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 10m 50s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 30m 52s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 49m 28s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 37m 42s
❌ openstack-operator-tempest-multinode FAILURE in 1h 58m 50s

@olliewalsh
Copy link
Contributor Author

/hold tempest failing, metadata api unreachable from VM

@olliewalsh
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 727,a52ef0637b99bc2c19e4bb877981bf4940e0a84f

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8b3e70cc55ec4a118e5a3f02d9e30c1e

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 15m 00s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 29m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 57m 46s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 46m 38s
❌ openstack-operator-tempest-multinode FAILURE in 1h 41m 59s

@olliewalsh olliewalsh force-pushed the tls_default branch 2 times, most recently from 9821e5d to 850fd43 Compare April 9, 2024 01:27
@olliewalsh
Copy link
Contributor Author

/remove-hold

@olliewalsh
Enable TLS-e by default
9e8cd27 
As there is no longer an external dependency, TLS-e can now be enabled
by default (with explicit opt-out e.g for adoption).

Depends-On: openstack-k8s-operators/dataplane-operator#754

Related: OSPRH-2038
stuggi
stuggi approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh olliewalsh merged commit 277d803 into openstack-k8s-operators:main Apr 9, 2024
7 checks passed
@stuggi stuggi mentioned this pull request Apr 9, 2024
Merged
karelyatin added a commit to karelyatin/ovn-operator that referenced this pull request Apr 10, 2024
@karelyatin
Fix ovn_controller tls args
2ca4015 
TLS support in ovn was originally added with [1], but tls args
got messed in [2], the issue got visible after
tls enabled by default[3], this patch fixes it.

[1] openstack-k8s-operators#234
[2] openstack-k8s-operators#233
[3] openstack-k8s-operators/openstack-operator#727

Related-Issue: OSPRH-2191
Depends-On: openstack-k8s-operators/openstack-operator#745
@karelyatin karelyatin mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuggi stuggi stuggi approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@stuggi stuggi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olliewalsh @stuggi @fao89 @openshift-merge-robot