Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstanceHA: Use deep-merge for FencingConfig #1023

Merged

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Apr 2, 2024

Required to allow additional FencingConfig to be added for compute nodes

Resolves: OSP-31777

Required to allow additional FencingConfig to be added for compute nodes

Resolves: OSP-31777
@olliewalsh olliewalsh requested a review from stuggi April 2, 2024 11:30
@openshift-ci openshift-ci bot requested review from abays and dprince April 2, 2024 11:30
@openshift-ci openshift-ci bot added the approved label Apr 2, 2024
@olliewalsh
Copy link
Contributor Author

/retest

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 4, 2024
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a0f5a53 into openstack-k8s-operators:master Apr 4, 2024
10 checks passed
@olliewalsh
Copy link
Contributor Author

/cherry-pick v1.3.x

@openshift-cherrypick-robot

@olliewalsh: new pull request created: #1047

In response to this:

/cherry-pick v1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants