Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Newtonsoft.Json reference #614

Closed
mnbeer opened this issue May 3, 2016 · 10 comments
Closed

Outdated Newtonsoft.Json reference #614

mnbeer opened this issue May 3, 2016 · 10 comments
Assignees

Comments

@mnbeer
Copy link

mnbeer commented May 3, 2016

Anything preventing the project from referencing Newtonsoft.Json 8+? The current dependency is more than a year-old and that can force some creative juggling when adding openstack.net to apps/libraries requiring newer Newtonsoft.Json versions.

@carolynvs carolynvs self-assigned this May 4, 2016
@carolynvs
Copy link
Member

I can't recall anymore why I pinned the json.net dependency at 6.*. I'll try updating it and see what explodes. 😄

@mnbeer
Copy link
Author

mnbeer commented May 4, 2016

Thanks and good luck!

@carolynvs
Copy link
Member

It's looking good. I need to do a bit more pre-release testing, but hope to put out a new version today.

@mnbeer
Copy link
Author

mnbeer commented May 4, 2016

That's great and will likely prevent many headaches (not just mine). Thanks for jumping on so quickly.

@carolynvs
Copy link
Member

I've published version 1.7.0-beta.2 to nuget.org. Would you mind trying that out and letting me know if you run into any issues? In one of my projects, I had to add an assembly binding redirect manually but I thought nuget was smart enough to add those automatically when a package is udpated...

If it all looks good, then this will go out officially in the 1.7.0 release next week.

@mnbeer
Copy link
Author

mnbeer commented May 4, 2016

Thanks. I'll give it a shot and let you know. I'm upgrading from v 1.3.4 so I may have a host of other breaking changes to wade through.

@mnbeer
Copy link
Author

mnbeer commented May 5, 2016

Things seem to be working fine for me with the caveat that I don't have sophisticated needs. I am only calling CreateObject, CopyObject, GetObject, and DeleteObject. The calls all work without any alteration of code; that makes me happy.

@carolynvs
Copy link
Member

Thanks, that's good enough for me! I'll report back here when 1.7.0 releases.

@carolynvs
Copy link
Member

@mnbeer Thanks for bringing up this issue. v1.7.0 with support for json.net 6-8 is available on nuget.

@mnbeer
Copy link
Author

mnbeer commented Jun 7, 2016

Nice. Thanks.

Matthew Nicholson Beer
The Foundry Software Development Co.
(314) 529-1455
matthew.beer@foundrysoftware.com

On Tue, Jun 7, 2016 at 4:32 PM, Carolyn Van Slyck notifications@github.com
wrote:

@mnbeer https://github.com/mnbeer Thanks for bringing up this issue.
v1.7.0 https://github.com/openstacknetsdk/openstack.net/releases/v1.7.0
with support for json.net 6-8 is available on nuget.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#614 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHSMZJy8PnaaYu__-K0hi36KNrsQIVIgks5qJeNhgaJpZM4IWsE-
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants