Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/anonymize site users #257

Merged
merged 14 commits into from
Oct 21, 2022

Conversation

nlsvgtr
Copy link
Collaborator

@nlsvgtr nlsvgtr commented Oct 14, 2022

Description

Anonimize site users contains two main parts:

  • make sure that siteadmins or project managers anonymize old sites
  • remove users that have been inactive for a certain amount of time

To do this the following changes have been made:

  • Add project.endDate to site.config
  • Add anonymize settings to site.config, i.e. some timers on when to anoymize users
  • Add extra noticications layer to site.config, i.e. split the one existing 'to' email address into two: one for a projectmanager, and one for a site admin.
  • Add lastLogin to user
  • Add sites-with-issues route
  • Add cron to automatically warn and anonymize inactive users
  • Add cron to automatically notify about project enddate
  • Add cron to automatically notify about sites-with-issues
  • Add generic lock use - fixes issue #255
  • Remove sequelize.paranoid from locks
  • Refactor: Move site.config.projectHasEnded to site.config.project.projectHasEnded

Issue reference

It does, incidentally, fix issue #255

Type of change

New feature

Documentation

Documentation has not been written yet; this will hopefully be done before this code is merged

See also

issue #256
openstad/openstad-management-panel#76
openstad/openstad-react-admin#14

@nlsvgtr nlsvgtr marked this pull request as ready for review October 17, 2022 11:15
Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this new feature and the way you've implemented it! Just a few small comments.

config/default.js Outdated Show resolved Hide resolved
src/services/sites-with-issues.js Outdated Show resolved Hide resolved
src/cron/send_site_issues_notifications.js Outdated Show resolved Hide resolved
src/models/Site.js Outdated Show resolved Hide resolved
@nlsvgtr nlsvgtr merged commit ece5605 into openstad:devel Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants