Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package dependencies #227

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

stijnvandervegt
Copy link
Collaborator

Preparation to publish @openstad/cms package to npm (or other package registry).

  • Move dependencies to @openstad/cms package
  • Update cms package version
  • Change lerna registry to npm

Note: It's possible to publish the cms package with lerna, but feel free to just use npm publish or something else. At the end it would be nice to include the publish script in the ci pipeline.
For example: when pushing a tag the ci pipeline also publish the tagged version to the registry.

@nlsvgtr nlsvgtr marked this pull request as ready for review February 8, 2022 12:39
@nlsvgtr
Copy link
Contributor

nlsvgtr commented Feb 8, 2022

@stijnvandervegt could you check this please:
After merging and reolving conflicts my local version does not work anymore. The error

The configured bundle apostrophe was not found in npm
suggests that there's something wrong in reading the package.json, and indeed: changing

  "dependencies": {
    "@openstad/cms": "file:packages/cms",
    "dotenv": "^8.2.0"
  },

back to

  "dependencies": {
    "@openstad/cms": "file:packages/cms",
    "apostrophe": "2.220.7",
    "apostrophe-area-structure": "^1.1.1",
    "apostrophe-blog": "^2.1.2",
    "apostrophe-palette": "^2.0.30",
    "apostrophe-workflow": "2.39.5",
    "dotenv": "^8.2.0",
    "memory-cache": "^0.2.0",
    "morgan": "^1.10.0",
    "npm": "^8.0.0",
    "query-string": "^6.13.8",
    "svg-captcha": "^1.4.0",
    "dotenv": "^8.2.0"
  },

makes it work again.

Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants