Feature/extend arguments widget #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…openstad-frontend into feature/extend-arguments-widget
rudivanhierden
requested changes
Jul 31, 2023
There was a problem hiding this comment.
The field is still commented so it won't show.
| @@ -86,28 +81,60 @@ module.exports = { | |||
| { | |||
| name: 'advanced', | |||
| label: 'Advanced', | |||
| fields: ['replyingEnabled', 'votingEnabled'] | |||
| fields: ['replyingEnabled', 'votingEnabled', 'showLastNameForArguments', 'showLastNameForReactions', 'ideaId'] | |||
There was a problem hiding this comment.
showLastNameForArguments and showLastNameForReactions are not defined in this file. I don't think they belong in this PR because they are not within the scope of the requested change — we only need the ideaId in this field.
Comment on lines
+128
to
+138
| self.addHelpers({ | ||
| showLastName: function (type, widget, user) { | ||
| if (type == 'reactions' && (widget.showLastNameForReactions == 'yes' || (widget.showLastNameForReactions == 'adminonly' && user.role == 'admin'))) { | ||
| return user.lastName; | ||
| } else if (type == 'arguments' && (widget.showLastNameForArguments == 'yes' || (widget.showLastNameForArguments == 'adminonly' && user.role == 'admin'))) { | ||
| return user.lastName; | ||
| } | ||
|
|
||
| return ''; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Same goes for this helper — should not be in this PR I think.
|
#416 Vervangt deze PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include
Issue reference
Fixes # (issue)
Type of change
Is it a new feature, bug fix, code improvement, etc.
If it is a breaking change what needs to be done to fix that
Documentation
Is the documentation updated, maybe a link
Tests
(How) has the change been tested
Branch
If the branch to merge to is not development