Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): component alignment issue on left side of login page (#899) #900

Merged

Conversation

tsahil01
Copy link
Contributor

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation

Description

Fixes Alignment Issue on Left Side of Login Page (#899)

Fixed alignment issue on the left side of the login page at https://www.openstatus.dev/app/login. Content is now center-aligned and text sizes adjusted for improved visual consistency.

Before this PR

Before

sm devices -

Before-mobile-view

After this PR

After

sm devices -

image

Looks good on mobile devices as well

Related Issue (optional)

Fixes #899

Copy link

vercel bot commented Jun 28, 2024

@tsahil01 is attempting to deploy a commit to the OpenStatus Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openstatus-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 8:54am

@mxkaske
Copy link
Member

mxkaske commented Jun 28, 2024

Hey @tsahil01! I agree with you, centering the text on mobile feels much better! On larger device, I see it less as a problem but that’s just a personal preference. What do you think?

Thanks for improving OpenStatus.

@tsahil01
Copy link
Contributor Author

Hi @mxkaske! Thanks for the feedback! I believe centring the text enhances the user experience across all device sizes, making it more consistent and visually appealing.

What do you think about merging the PR as it is?
I'm also open to making further improvements based on your suggestions.

Copy link
Member

@mxkaske mxkaske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first start with mobile/tablet version if you are fine with it.

apps/web/src/app/app/(auth)/login/layout.tsx Outdated Show resolved Hide resolved
apps/web/src/app/app/(auth)/login/layout.tsx Outdated Show resolved Hide resolved
@tsahil01
Copy link
Contributor Author

Hi @mxkaske , I'll implement the mobile/tablet changes and push the updates soon.
Thanks!

@tsahil01
Copy link
Contributor Author

I've implemented the mobile/tablet version changes as suggested and pushed the updates.

Mobile/Tablet -

image

Larger screen -

image

@mxkaske mxkaske changed the title Fix component alignment issue on left side of login page (#899) fix(mobile): component alignment issue on left side of login page (#899) Jun 29, 2024
@mxkaske mxkaske merged commit 69a628e into openstatusHQ:main Jun 29, 2024
5 checks passed
@mxkaske
Copy link
Member

mxkaske commented Jun 29, 2024

Appreciate it! Merged!

@tsahil01 tsahil01 deleted the fix/issue-899-login-page-alignment branch June 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component alignment issue on Left Side of the login page
2 participants