allow setting of cache control header on s3 text file #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveburkett
approved these changes
Jul 11, 2019
spec/s3_text_file_spec.rb
Outdated
| expect(instance.read).to eq "something new" | ||
| end | ||
| end | ||
|
|
||
| it 'sets the cache control header' do | ||
| with_temp_bucket(files: [{key: key, path: test_file_path}]) do | ||
| instance = described_class.new(bucket_name: bucket_name, bucket_region: region, key: key) |
There was a problem hiding this comment.
optional of course. this could be cleaned up a bit via a subject http://www.betterspecs.org/#subject
| body: StringIO.new(string_contents) | ||
| } | ||
|
|
||
| args[:content_type] = content_type if !content_type.nil? |
There was a problem hiding this comment.
args[:content_type] = content_type if content_type ? (a bit more concise)
There was a problem hiding this comment.
Yeah... for some reason I generally don't do that. Some sort of long-lasting objection to boolean checks on non boolean things in C++ I think :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow setting of cache control header on s3 text file