Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show erros from aws console in command line - AWS part #62

Merged
merged 20 commits into from
Jun 1, 2020

Conversation

…pdates of stacks and a test to prove it works
@KarinaMendez2 KarinaMendez2 marked this pull request as draft April 21, 2020 13:31
@KarinaMendez2 KarinaMendez2 marked this pull request as ready for review April 22, 2020 23:07
Copy link
Contributor

@janKozie1 janKozie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving those as comments since I'm not exactly sure if they are right

lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
spec/stack_spec.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/deployment_base.rb Outdated Show resolved Hide resolved
@jpslav
Copy link
Member

jpslav commented May 11, 2020

You'll also need to commit your VCR cassettes once they are working. Definitely do test that they work when you set VCR_OPTS_RECORD=none as that is what Travis will be doing.

lib/openstax/aws/deployment_base.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/deployment_base.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
…mplified methods and added spec for stack status hash
lib/openstax/aws/deployment_base.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
@jpslav jpslav mentioned this pull request May 15, 2020
KarinaMendez2 and others added 3 commits May 19, 2020 15:07
… events and statuses to separate classes, added spec for actual errors in events, updated vcrs
lib/openstax/aws/stack_event.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack_status.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/stack.rb Outdated Show resolved Hide resolved
lib/openstax/aws/deployment_base.rb Outdated Show resolved Hide resolved
@jpslav jpslav merged commit bbb0f69 into master Jun 1, 2020
@jpslav jpslav deleted the show_errors_command branch June 1, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants