-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show erros from aws console in command line - AWS part #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdates of stacks and a test to prove it works
…nt and return their latest failed events
object returned in deployment status for failure
janKozie1
reviewed
Apr 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving those as comments since I'm not exactly sure if they are right
jpslav
reviewed
May 1, 2020
jpslav
requested changes
May 11, 2020
You'll also need to commit your VCR cassettes once they are working. Definitely do test that they work when you set |
jpslav
requested changes
May 14, 2020
…mplified methods and added spec for stack status hash
jpslav
requested changes
May 15, 2020
Merged
Suggested changes to #62
… events and statuses to separate classes, added spec for actual errors in events, updated vcrs
jpslav
requested changes
May 21, 2020
…s to them and updated vcrs
jpslav
requested changes
May 27, 2020
…at becomes and array) from stack_statuses
jpslav
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for: https://app.zenhub.com/workspaces/openstax-unified-5b71aabe3815ff014b102258/issues/openstax/unified/971