Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Packer debugging by using getc instead of gets and unbuffered mode #81

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

Dantemss
Copy link
Member

@Dantemss Dantemss commented Oct 8, 2020

Packer's debug mode prints lines that do not end on a newline and then waits for the user to press Enter.
Since aws-ruby was waiting for a whole line to print, these lines were not printing and Packer would sit there waiting for Enter with no indication to the user.

@Dantemss Dantemss self-assigned this Oct 8, 2020
@Dantemss Dantemss merged commit e68ce5e into master Oct 20, 2020
@Dantemss Dantemss deleted the packer_debug branch October 20, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants