-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move module_files.mimetype to files.media_type #403
Conversation
…dia_type These changes have been introduced as part of openstax/cnx-archive#403.
These changes have been introduced as part of openstax/cnx-archive#403.
Looking at legacy code, https://github.com/Rhaptos/Products.RhaptosModuleStorage seems to treat the mimetype value as write only, so I think this is even a backwards-compatible change |
👍 |
These changes have been introduced as part of openstax/cnx-archive#403.
What happens when legacy wants to write to |
I'm preparing a matching PR for RhaptosModuleStorage, which will shift where the mimetype is stored, to match. |
386e113
to
facf485
Compare
I've split the migration in two. Have another look. |
facf485
to
832aa14
Compare
👍 FYI Now that there are two migrations, if you want to just run the first migration, you can do something like:
|
Excellent! |
Move module_files.mimetype to files.media_type
This puts the mime-type (aka media type and content type) on the files table.
This adds the db-migrator feature to this project. Please review this part of the pull request carefully.