Cleanup ENV #364
Open
Cleanup ENV #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanstitt
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new interns are both on windows machines, they were running into some issues with the
frontend/bin/envfile. I tried to investigate if we could potentially just remove that file and rely on env variables. it seems the main purpose ofbin/envwas to pass along theVITE_<var>env variables for staging/prod.The GA_UA tags should be irrelevant now as that was the former version of GA that is no longer used.
The GTM tag is shared between prod and staging (checked with Tom on that), so simplified that down to one config
I also set the
VITE_GTAG_IDandVITE_SENTRY_DSNon staging/prod preemptively for whenever this gets merged