add method that generate roman numbers up to 100 #462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done for Intellectual Property. This book has over 80 footnotes in roman numbers, so I added method that generate them rather then create bigger constant. I had problems with instance variable. Adding
attr_reader
orattr_accesor
at the beginning of the class didn't help, methods from this class treated variable as nil. I found another solution, but if someone have better idea how to handle this let me know 😉