Fixed the delete exercise image API url #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 29.34% 29.34%
=======================================
Files 3 3
Lines 92 92
Branches 2 2
=======================================
Hits 27 27
Misses 65 65Continue to review full report at Codecov.
|
|
Hehe codecov AND coveralls? |
|
looks good to me @Dantemss |
Dantemss
force-pushed
the
fix_delete_api_url
branch
16 times, most recently
from
e545cc8
to
fa924be
Compare
…hment; Renamed the upload form parameter to "file"
Dantemss
force-pushed
the
fix_delete_api_url
branch
2 times, most recently
from
730a22f
to
0dca3ba
Compare
|
@nathanstitt sorry, but maybe another review is needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with openstax/exercises#186
Manually tested on exercises-dev...