Add historic=pillory preset

[AntMadeira]

Hi there.

In Portugal, there are thousands of pillorys like this.
They're important historic and touristic monuments and I think this is would be a good preset to add to iD, and a very necessary one for many mappers of South of Europe.

Regards!

[animesh-007]

I would like to work on it.

[animesh-007]

Hi, I had few queries regarding the issue i.e, Do you need pillory as a suggestion in the suggestion list??

[AntMadeira]

Hi, I had few queries regarding the issue i.e, Do you need pillory as a suggestion in the suggestion list??

Is this question for me? If so, can you explain better?

[animesh-007]

Do you want Pillory to come as a suggestion here?

[AntMadeira]

Yes, that's the scope of this request: add it to presets so that it can be searchable on iD.

[animesh-007]

Hi, Thank you for allowing me to work on this issue. I was able to solve the issue. Also, I have attached a screenshot of my work. I wanted to ask what would you suggest the branch commit name and it would be great if you could let me know if there are any further modification needed with the current change.

[AntMadeira]

I'm the one that has to thank you, not the other way around. ;)
If iD has included pillory into presets, that's perfect.

I would suggest a different image to the pillory, since it has a very peculiar shape.
You can check here for some inspiration:
https://es.wikipedia.org/wiki/Rollo_(administraci%C3%B3n)
https://pt.wikipedia.org/wiki/Pelourinho

[animesh-007]

I have updated the icon, Does it looks fine now??

[bhousel]

For the icon, let's just use the generic maki-star for now, like other generic tourist attractions, and open an issue in https://github.com/ideditor/temaki for @quincylvania or me to draw a better one.

[bhousel]

I would suggest a different image to the pillory, since it has a very peculiar shape.
You can check here for some inspiration:
https://es.wikipedia.org/wiki/Rollo_(administraci%C3%B3n)
https://pt.wikipedia.org/wiki/Pelourinho

@AntMadeira - I looked at these images on these links and it's definitely not what I was expecting.

Aren't most pillories like this thing where they lock you in so people can throw vegetables at your face?

[bhousel]

Actually let's just leave it how it is with the monument icon. That's fine too.. @animesh-007 can you send the PR?

[animesh-007]

Thank you for the suggestions, I have already made a PR and here's the link to it #7310
Hope to hear your comments soon 😃

[AntMadeira]

For the icon, let's just use the generic maki-star for now, like other generic tourist attractions, and open an issue in https://github.com/ideditor/temaki for @quincylvania or me to draw a better one.

A pillory is not a tourist attraction per se, it's more of a historic monument (almost every one of them are national monuments in Portugal) That image that you show above is not a pillory. It could be a pillory in the Middle Ages in central Europe, but they were provisory. These pillories are permanent (they existed in the middle of towns) and were made from various kinds of stone, granite, marble, sandstone, etc. Please, check Wikipedia or OSM wiki to see more adequate images.
Since this is such a peculiar monument (there's no other similar) it could have something different from a tower image, but that's not the most important. The preset is already in place, and that's the most important thing.

[AntMadeira]

Thank you for the suggestions, I have already made a PR and here's the link to it #7310
Hope to hear your comments soon 😃

That image seems ok. Thank you!