Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grid to get country code in place of Nominatim #2268

Closed
wants to merge 2 commits into from

Conversation

hlaw
Copy link
Contributor

@hlaw hlaw commented Jun 23, 2014

PR further to #2258, with the tiles checked in and amendments made. Using iD.Context rather than the UI to track movements. The Makefile points to osmlab rather than my repo for tiles update, assuming the repo name is country-code-grid.

Thank you!

@cschwarz
Copy link
Contributor

As this approach is not async anymore, you can remove the init event and isInitialized.

Otherwise it looks nice and opens up many possibilities. 👍

@hlaw
Copy link
Contributor Author

hlaw commented Jun 24, 2014

In relation to what I have been thinking of at #2254, if we support retrieval of a list of nearby cities / towns / suburb from nominatim for the addr:city / town fields etc as specified in the country specific rules (rather than rely on the data currently loaded into iD), then the async code might be needed again very soon. It might perhaps be useful to keep this for the expansion?

@jfirebaugh
Copy link
Member

The downside to using the current center of the viewport for the address format is if you are editing near a border, you get the address format for the neighboring country instead. The old approach based the address format for a feature on the location of the feature itself, rather than the map center. Can we continue to do this?

@hlaw
Copy link
Contributor Author

hlaw commented Jul 2, 2014

Sure. Since it would be useful to maintain a global state on the country for general use, I would suggest the following implementation -

(a) when any object is selected, the location of the centroid of the selected object is used;
(b) otherwise when hovering, keep track the location of the mouse pointer.

The address format displayed during hovering and selection would then be based on the location of the feature.

@bhousel
Copy link
Member

bhousel commented Feb 17, 2016

This PR has gone stale.. @hlaw are you still interested in merging this? I noticed that country-code-grid never made it over to osmlab..

@bhousel
Copy link
Member

bhousel commented May 13, 2016

Closing as stale - besides the nominatim lookups work pretty well and including this country code grid would drastically grow the size of the iD distribution.

@bhousel bhousel closed this May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants