Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mod_tile not having a valid storage context (causing a segmentation fault) #398

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented Mar 2, 2024

This only seems to happen after a delay pool is created (i.e. when ModTileEnableTileThrottling is enabled) and is then being manipulated.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.23%. Comparing base (2de946d) to head (4dfde06).

Files Patch % Lines
src/mod_tile.c 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   75.29%   75.23%   -0.06%     
==========================================
  Files          24       24              
  Lines        5626     5625       -1     
==========================================
- Hits         4236     4232       -4     
- Misses       1390     1393       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hummeltech hummeltech merged commit b37cfd9 into openstreetmap:master Mar 3, 2024
1 check passed
@hummeltech hummeltech deleted the StorageContextMissing branch March 3, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants