Refine zooming and panning for note and data layers #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| page.load = function () { | ||
| function initialize(loadType) { |
|
I'm seeing some weird behaviour with this where leaflet seems to "crash" and doesn't finish loading tiles properly or allow me to pan or zoom. As best I can tell one trigger is loading a note from the URL bar when my current zoom is not 16 so that it tries to do a zoom after loading but gets stuck with a broken map. |
|
I was only able to reproduce the problem when directly visiting a notes page, did you see it anywhere else? It's a weird issue because as you said zoom 16 worked, but none of the others did. Also just changing setView to panTo works fine. Seems like it was some kind of timing issue, I'm not sure where, but making it a callback to initialize works fine. |
|
Merged as a796c41. |
This was referenced Dec 9, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #629 #643, improves #644.
Only centers and/or zooms when clicking a note or data on a new page load (such as directly visiting /note/xx) or if the data doesn't completely fit inside the map view. Otherwise the map view doesn't move and the item is simply highlighted.